Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/ts-project-write-api

On Mon, Dec 16, 2013 at 8:28 PM, Ursula Junque wrote:

> Review: Needs Information
>
> > A binary package may not be associated with a source package, it may just
> > refer to a binary package that is available in the archive, but not
> otherwise
> > seeded in the base image.
> >
> > The changes to the binary package list should only become permanent
> after the
> > ticket is successfully processed. Once the ticket is completed, they can
> then
> > be integrated into the package list for future builds.
>
>
> I believe we have a different understanding of what this binary package
> list is. In my understanding for phase 0 this would be a list of
> seeded/relevant binary packages that should be tested when building and
> testing images, but as dep8 tests are part of the sources this list would
> be used only as input to an external script that should come up with the
> sources list, hence we storing only the source packages list, not binary
> (as described in the docs).
>
> This is only the initial implementation of what used to be the "project
> manager" component (similar to cu2d-config). In your scenario, this list
> would change per ticket? It seems to me that this is completely different
> than what was understood when we discussed the tests manager/project
> manager/ticket system split.
>
>
>
I had the same understanding that Ursula did.

> >
> > For example:
> >
> > After a few successful builds, the binary package list contains unity8,
> mir
> > and libmir. The most recently built package will contain these packages.
> >
> > A new request is made to build a source package from the autopilot source
> > package and add python3-autopilot and python3 to the binary package
> list. When
> > this builds, python3-autopilot and python3 needs to be included in the
> image,
> > but it only gets promoted to the master binary package list after a
> successful
> > build and test.
>
>
> >
> > With two different API calls to add binary and source packages, it's
> unclear
> > to me how a build request with source and binary package updates would be
> > atomic.
>
>