Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/ticket-complete

Revision history for this message
Andy Doan (doanac) wrote :

On 01/22/2014 10:54 AM, Chris Johnston wrote:
> On Wed, Jan 22, 2014 at 11:36 AM, Andy Doan <email address hidden>wrote:
>
>> do we really want this API to be an HTTP GET and not a PATCH?
>>
> You aren't actually patching anything. I'm not sure though?

Things are being changed:

219 + queryset.current_workflow_step = TicketWorkflowStep.COMPLETED.value
220 + queryset.status = TicketWorkflowStepStatus.COMPLETED.value
221 + queryset.save()

Normally a GET implies a read-only operation. This is doing writes. If
we move to a secure model someday - we could easily forget about this
method.

« Back to merge proposal