Merge lp:~cjohnston/ubuntu-ci-services-itself/more-tarmac-testing into lp:ubuntu-ci-services-itself
Proposed by
Chris Johnston
Status: | Merged |
---|---|
Approved by: | Chris Johnston |
Approved revision: | 216 |
Merged at revision: | 215 |
Proposed branch: | lp:~cjohnston/ubuntu-ci-services-itself/more-tarmac-testing |
Merge into: | lp:ubuntu-ci-services-itself |
Diff against target: |
48 lines (+11/-5) 2 files modified
tarmac.sh (+5/-0) tests/test_run.py (+6/-5) |
To merge this branch: | bzr merge lp:~cjohnston/ubuntu-ci-services-itself/more-tarmac-testing |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Andy Doan (community) | Approve | ||
Chris Johnston (community) | Needs Resubmitting | ||
Review via email:
|
Commit message
Add juju-deployer/
To post a comment you must log in.
46 + os.fchmod( fp.fileno( ), stat.S_IWUSR) '__builtin_ _.open' , side_effect=e):
47 + with mock.patch(
I would think you'd need one or the other, but not both. ie - if you make the file non-readable, you shouldn't shouldn't need to mock. or if you mock, you shouldn't have to alter file permssions.