Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/fix-flake8-issues

Revision history for this message
Vincent Ladeuil (vila) wrote :

> We should adhere to pep8

+1

Yet, it's not good if it's not automatic. It's on my TODO list as part of our test story but not at the top yet (ucitests provides a base class that can be used for that but does not work (yet) on precise).

...

Now that I think about it, I should just skip that on precise, I don't think there are a lot of us developing on precise ... will make a MP later.

...

In fact, I already did almost all that is needed in ucitests-0.0.8, so less work than I think.

review: Approve

« Back to merge proposal