Ubuntu CI Services

Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/fix-flake8-issues

  1. fix-flake8-issues
  2. Merge into trunk
Revision history for this message
Ursula Junque (ursinha) wrote :

The changes look good (can't disagree with flake8 cleanup :)). I see that all cupstream2distro reused code needs pep8 love, so might be too much for this branch, but I found three worth fixing in this branch:

branch-source-builder/watch_ppa.py:174:1: F821 undefined name 'UPLOAD_LIST'
ci-utils/ci_utils/nova_client/__init__.py:75:1: F841 local variable 'id' is assigned to but never used
cli/tests/test_utils.py:34:1: E302 expected 2 blank lines, found 1

Other than that that's great.

« Back to merge proposal