Code review comment for lp:~cjohnston/ubuntu-ci-services-itself/TS-integration-tests

Revision history for this message
Andy Doan (doanac) wrote :

25 +def delete_virtual_env(temp_dir):
26 + remove = ('rm -rf %s' % temp_dir)
27 + subprocess.check_call([remove], shell=True)

Is there a reason shutil.rmtree isn't being used here instead?

//massive bikeshedding, but a style suggestion for the future:
55 + args = ('%s develop' % os.path.join(
56 + os.path.dirname(__file__), '../../ci-utils/setup.py'))

could be:

    p = os.path.join(os.path.dirname(__file__), '../../ci-utils/setup.py'))
    args = '%s develop' % p

and then you don't get weird multi-line parentheses to match with your eyes.

92 + def test_ticket_in_webui_ticket_list(self):

This method only works when "test_create_ticket_via_cli" is called first. Its probably smarter if you move the ticket creation logic from "test_create_ticket_via_cli" into your setUp method and then just let your 2 test methods assert that both the ticket-system and webui are displaying what we expect.

« Back to merge proposal