Ubuntu CI Services

Merge lp:~cjohnston/ubuntu-ci-services-itself/1286168 into lp:ubuntu-ci-services-itself

  1. 1286168
  2. Merge into trunk
Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 393
Merged at revision: 393
Proposed branch: lp:~cjohnston/ubuntu-ci-services-itself/1286168
Merge into: lp:ubuntu-ci-services-itself
Diff against target: 148 lines (+87/-8)
6 files modified
webui/complete.html (+35/-0)
webui/index.html (+3/-2)
webui/packages.html (+3/-2)
webui/status.html (+3/-2)
webui/ticket.html (+3/-2)
webui/webui_complete.js (+40/-0)
To merge this branch: bzr merge lp:~cjohnston/ubuntu-ci-services-itself/1286168
Reviewer Review Type Date Requested Status
Evan (community) Approve
Andy Doan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211126@code.launchpad.net

Commit message

Adds a 'completed' ticket page

Description of the change

After a ticket has completed, it has no place to go. This will give it a home.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:393
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/429/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/429/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

25 + <li><a href="/" class="first">Ticket list</a></li>
26 + <li><a href="/complete.html">Completed tickets</a></li>
27 + <li><a href="/packages.html">Published packages</a></li>
28 + <li><a href="/status.html">Engine health</a></li>

I think L26 should have the "class=first" option and not L25?

Revision history for this message
Andy Doan (doanac) wrote :

ignore my comment

review: Approve
Revision history for this message
Evan (ev) wrote :

+ <li><a href="/" class="first">Ticket list</a></li>

Maybe that should become "Unfinished tickets"? When I read it I always think that it's the entire list of tickets, which it is not.

144 + console.log("failure: ", tx, r, e);

I'd suggest Y.webui.main_table.showMessage(json_error_msg); in addition to logging on the console.

Don't let me block merging though. +1

Revision history for this message
Chris Johnston (cjohnston) wrote :

Ev, currently, Ticket list still holds failed tickets too.. so yes, it sounds wrong, but also Unfinished tickets (or open tickets) would be just as wrong... I hope to get a failed tickets page in as well, which would open this up for changes..

Thinking about it now... Maybe keep Ticket list as the main nav, then under that 'Open' 'Completed' 'Failed'?

Revision history for this message
Evan (ev) :
review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

Tickets in flight ?

Flying tickets ? ;)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file 'webui/complete.html'
--- webui/complete.html 1970-01-01 00:00:00 +0000
+++ webui/complete.html 2014-03-14 19:21:12 +0000
@@ -0,0 +1,35 @@
1<html>
2 <head>
3 <link href='https://fonts.googleapis.com/css?family=Ubuntu:400,300,300italic,400italic,700,700italic|Ubuntu+Mono' rel='stylesheet' type='text/css' />
4 <script type="text/javascript" src="http://yui.yahooapis.com/3.14.0/build/yui/yui.js"></script>
5 <script type="text/javascript" src="webui.js"></script>
6 <script type="text/javascript" src="webui_complete.js"></script>
7 <link rel="stylesheet" type="text/css" media="screen" href="ubuntu-styles.css" />
8 <link rel="stylesheet" href="webui.css">
9 <title>Ubuntu CI Engine - Completed tickets</title>
10 </head>
11 <body>
12 <header class="banner global" role="banner">
13 <nav role="navigation" class="nav-primary nav-right">
14 <div class="logo">
15 <a class="logo-ubuntu" href="/">
16 <img width="118" height="27" src="logo-ubuntu-orange.png" alt="Ubuntu logo for print" />
17 <span>CI Engine</span>
18 </a>
19 </div>
20 <ul>
21 <li><a href="/" class="first">Ticket list</a></li>
22 <li><a href="/complete.html">Completed tickets</a></li>
23 <li><a href="/packages.html">Published packages</a></li>
24 <li><a href="/status.html">Engine health</a></li>
25 </ul>
26 </nav>
27 </header><!-- /#header -->
28
29 <div class='container_15 clearfix'>
30 <div class="wrapper">
31 <div id="main-content" class="inner-wrapper">
32 <table id='table' class='yui3-skin-sam'></table>
33 </div></div></div>
34 </body>
35</html>
036
=== modified file 'webui/index.html'
--- webui/index.html 2014-03-14 10:37:28 +0000
+++ webui/index.html 2014-03-14 19:21:12 +0000
@@ -19,8 +19,9 @@
19 </a>19 </a>
20 </div>20 </div>
21 <ul>21 <ul>
22 <li><a href="/" class="first ">Ticket list</a></li>22 <li><a href="/" class="first">Ticket list</a></li>
23 <li><a href="/packages.html" class="first ">Published packages</a></li>23 <li><a href="/complete.html">Completed tickets</a></li>
24 <li><a href="/packages.html">Published packages</a></li>
24 <li><a href="/status.html">Engine health</a></li>25 <li><a href="/status.html">Engine health</a></li>
25 </ul>26 </ul>
26 </nav>27 </nav>
2728
=== modified file 'webui/packages.html'
--- webui/packages.html 2014-03-11 20:01:52 +0000
+++ webui/packages.html 2014-03-14 19:21:12 +0000
@@ -18,8 +18,9 @@
18 </a>18 </a>
19 </div>19 </div>
20 <ul>20 <ul>
21 <li><a href="/" class="first ">Ticket list</a></li>21 <li><a href="/" class="first">Ticket list</a></li>
22 <li><a href="/packages.html" class="first ">Published packages</a></li>22 <li><a href="/complete.html">Completed tickets</a></li>
23 <li><a href="/packages.html">Published packages</a></li>
23 <li><a href="/status.html">Engine health</a></li>24 <li><a href="/status.html">Engine health</a></li>
24 </ul>25 </ul>
25 </nav>26 </nav>
2627
=== modified file 'webui/status.html'
--- webui/status.html 2014-03-14 10:37:28 +0000
+++ webui/status.html 2014-03-14 19:21:12 +0000
@@ -18,8 +18,9 @@
18 </a>18 </a>
19 </div>19 </div>
20 <ul>20 <ul>
21 <li><a href="/" class="first ">Ticket list</a></li>21 <li><a href="/" class="first">Ticket list</a></li>
22 <li><a href="/packages.html" class="first ">Published packages</a></li>22 <li><a href="/complete.html">Completed tickets</a></li>
23 <li><a href="/packages.html">Published packages</a></li>
23 <li><a href="/status.html">Engine health</a></li>24 <li><a href="/status.html">Engine health</a></li>
24 </ul>25 </ul>
25 </nav>26 </nav>
2627
=== modified file 'webui/ticket.html'
--- webui/ticket.html 2014-03-14 18:27:36 +0000
+++ webui/ticket.html 2014-03-14 19:21:12 +0000
@@ -18,8 +18,9 @@
18 </a>18 </a>
19 </div>19 </div>
20 <ul>20 <ul>
21 <li><a href="/" class="first ">Ticket list</a></li>21 <li><a href="/" class="first">Ticket list</a></li>
22 <li><a href="/packages.html" class="first ">Published packages</a></li>22 <li><a href="/complete.html">Completed tickets</a></li>
23 <li><a href="/packages.html">Published packages</a></li>
23 <li><a href="/status.html">Engine health</a></li>24 <li><a href="/status.html">Engine health</a></li>
24 </ul>25 </ul>
25 </nav>26 </nav>
2627
=== added file 'webui/webui_complete.js'
--- webui/webui_complete.js 1970-01-01 00:00:00 +0000
+++ webui/webui_complete.js 2014-03-14 19:21:12 +0000
@@ -0,0 +1,40 @@
1YUI().use('io', 'jsonp', 'webui', 'datatable-mutable', function(Y) {
2
3 var table = new Y.webui.make_main_table('#table');
4 if (Y.webui.main_table) {
5 Y.webui.main_table.showMessage("loading data...");
6 }
7
8 Y.io(Y.webui.url_prefix + "ticketstatus/?current_workflow_step=1000", {
9 on: {
10 success: function (tx, r) {
11 var data,
12 i;
13 console.log("success");
14
15 try {
16 data = Y.JSON.parse(r.responseText);
17 } catch (e) {
18 Y.webui.main_table.showMessage(json_error_msg);
19 return;
20 }
21
22 if (data.objects && data.objects.length !== 0) {
23 for (i = 0; i < data.objects.length; i += 1) {
24 if (data.objects[i]) {
25 Y.webui.add_item(data.objects[i]);
26 }
27 }
28 Y.webui.check_statuses();
29 }
30 if (Y.webui.main_table.data.size() === 0) {
31 Y.webui.main_table.showMessage("No results found");
32 }
33 Y.webui.done_loading = true;
34 },
35 failure: function (tx, r, e) {
36 console.log("failure: ", tx, r, e);
37 }
38 }
39 });
40});

Subscribers

People subscribed via source and target branches