Merge lp:~cjohnston/summit/required-fail into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Michael Hall
Approved revision: 498
Merged at revision: 498
Proposed branch: lp:~cjohnston/summit/required-fail
Merge into: lp:summit
Diff against target: 116 lines (+11/-9)
6 files modified
summit/schedule/templates/schedule/by_room.html (+1/-1)
summit/schedule/templates/schedule/by_track.html (+1/-1)
summit/schedule/templates/schedule/daily.html (+5/-5)
summit/schedule/templates/schedule/meeting.html (+1/-1)
summit/schedule/templates/schedule/virtual_meeting.html (+1/-1)
summit/schedule/views.py (+2/-0)
To merge this branch: bzr merge lp:~cjohnston/summit/required-fail
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Adnane Belmadiaf Needs Fixing
Review via email: mp+151574@code.launchpad.net

Commit message

Fixes users not being able to see that they are required.

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

I think it should be {% if participant.participation == 'REQUIRED' %}

review: Needs Fixing
lp:~cjohnston/summit/required-fail updated
498. By Chris Johnston

oops

Revision history for this message
Michael Hall (mhall119) wrote :

Looks good, tests pass

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/templates/schedule/by_room.html'
2--- summit/schedule/templates/schedule/by_room.html 2013-01-10 21:37:16 +0000
3+++ summit/schedule/templates/schedule/by_room.html 2013-03-04 18:57:21 +0000
4@@ -54,7 +54,7 @@
5 <br /><b>Participants:</b>
6 <div>{% for participant in agenda.meeting.participant_set.all %}
7 <div>
8- {% if participant.required %}
9+ {% if participant.participation == 'REQUIRED' %}
10 <img class="icon" src="/media/img/required.png" title="required" alt="(required)">
11 {% else %}
12 <img class="icon" src="/media/img/attending.png" alt="attending">
13
14=== modified file 'summit/schedule/templates/schedule/by_track.html'
15--- summit/schedule/templates/schedule/by_track.html 2013-01-10 21:37:16 +0000
16+++ summit/schedule/templates/schedule/by_track.html 2013-03-04 18:57:21 +0000
17@@ -49,7 +49,7 @@
18 <br /><b>Participants:</b>
19 <div>{% for participant in agenda.meeting.participant_set.all %}
20 <div>
21- {% if participant.required %}
22+ {% if participant.participation == 'REQUIRED' %}
23 <img class="icon" src="/media/img/required.png" title="required" alt="(required)">
24 {% else %}
25 <img class="icon" src="/media/img/attending.png" alt="attending">
26
27=== modified file 'summit/schedule/templates/schedule/daily.html'
28--- summit/schedule/templates/schedule/daily.html 2013-01-18 22:24:11 +0000
29+++ summit/schedule/templates/schedule/daily.html 2013-03-04 18:57:21 +0000
30@@ -62,7 +62,7 @@
31 <a href="{{agenda.meeting.meeting_page_url}}" style="color: #000000;" class="main-agenda-item-name">
32 {{agenda.meeting.title}}
33 </a>
34-
35+
36 {% if agenda.meeting.tracks.count > 0 %}
37 <span class="main-agenda-item-tracks">({% for track in agenda.meeting.tracks.all %}
38 {% ifnotequal forloop.counter 1 %}, {% endifnotequal %}{{ track.title }}
39@@ -76,7 +76,7 @@
40 <br /><b>Participants:</b>
41 <div>{% for participant in agenda.meeting.participant_set.all %}
42 <div>
43- {% if participant.required %}
44+ {% if participant.participation == 'REQUIRED' %}
45 <img class="icon" src="/media/img/required.png" title="required" alt="(required)">
46 {% else %}
47 <img class="icon" src="/media/img/attending.png" alt="attending">
48@@ -101,7 +101,7 @@
49 {% if agenda.meeting.spec_url %}<a href="{{ agenda.meeting.spec_url }}"><img class="icon" src="{{ MEDIA_URL }}img/gem-sm.png" title="Go to Blueprint" alt="Go to Blueprint" /></a>{% endif %}
50 </td>
51 </tr>
52-{% endfor %}
53+{% endfor %}
54 {% endif %}
55 </tbody>
56 </table>
57@@ -164,11 +164,11 @@
58 width: 25%;
59 text-align: center;
60 }
61-
62+
63 div.schedule-head .qrcode {
64 display: none;
65 }
66-
67+
68 #sub-nav-container {
69 margin-bottom: 0px;
70 }
71
72=== modified file 'summit/schedule/templates/schedule/meeting.html'
73--- summit/schedule/templates/schedule/meeting.html 2012-10-27 23:03:05 +0000
74+++ summit/schedule/templates/schedule/meeting.html 2013-03-04 18:57:21 +0000
75@@ -118,7 +118,7 @@
76 <div id="Attendees" class="span-5">
77 <h3>Attendees</h3>
78 {% for attendee in attendees %}
79- <a href="http://launchpad.net/~{{ attendee.user.username }}">{% if attendee.participation = 'REQUIRED' %}<strong>{% endif %}{{ attendee.name }}{% if attendee.required %}</strong>{% endif %}</a>{% if not forloop.last %}, {% endif %}
80+ <a href="http://launchpad.net/~{{ attendee.user.username }}">{% if attendee in required_attendees %}<strong>{% endif %}{{ attendee.name }}{% if attendee in required_attendees %}</strong>{% endif %}</a>{% if not forloop.last %}, {% endif %}
81 {% endfor %}
82 </div>
83 {% endifnotequal %}
84
85=== modified file 'summit/schedule/templates/schedule/virtual_meeting.html'
86--- summit/schedule/templates/schedule/virtual_meeting.html 2013-03-01 21:59:27 +0000
87+++ summit/schedule/templates/schedule/virtual_meeting.html 2013-03-04 18:57:21 +0000
88@@ -140,7 +140,7 @@
89 <div id="Attendees" class="span-4">
90 <h3>Attendees</h3>
91 {% for attendee in attendees %}
92- <a href="http://launchpad.net/~{{ attendee.user.username }}">{% if attendee.participation = 'REQUIRED' %}<strong>{% endif %}{{ attendee.name }}{% if attendee.required %}</strong>{% endif %}</a>{% if not forloop.last %}, {% endif %}
93+ <a href="http://launchpad.net/~{{ attendee.user.username }}">{% if attendee in required_attendees %}<strong>{% endif %}{{ attendee.name }}{% if rttendee in equired_attendees %}</strong>{% endif %}</a>{% if not forloop.last %}, {% endif %}
94 {% endfor %}
95 </div>
96 {% endifnotequal %}
97
98=== modified file 'summit/schedule/views.py'
99--- summit/schedule/views.py 2013-02-27 18:00:02 +0000
100+++ summit/schedule/views.py 2013-03-04 18:57:21 +0000
101@@ -462,6 +462,7 @@
102 agendaitems = meeting.agenda_set.all()
103 participants = meeting.participant_set.all()
104 attendees = meeting.attendees
105+ required_attendees = meeting.required_attendees
106 tracks = meeting.tracks.all()
107 user_is_attending = attendee is not None and attendee in meeting.attendees
108 user_is_participating = attendee is not None and attendee in [p.attendee for p in participants if not p.from_launchpad]
109@@ -481,6 +482,7 @@
110 'agenda_items': agendaitems,
111 'participants': participants,
112 'attendees': attendees,
113+ 'required_attendees': required_attendees,
114 'user_is_attending': user_is_attending,
115 'user_is_participating': user_is_participating,
116 'required': required,

Subscribers

People subscribed via source and target branches