Merge lp:~cjohnston/summit/display-sponsor-email into lp:summit

Proposed by Chris Johnston
Status: Merged
Approved by: Nigel Babu
Approved revision: 213
Merged at revision: 216
Proposed branch: lp:~cjohnston/summit/display-sponsor-email
Merge into: lp:summit
Diff against target: 49 lines (+1/-31)
1 file modified
summit/sponsor/templates/sponsor/review.html (+1/-31)
To merge this branch: bzr merge lp:~cjohnston/summit/display-sponsor-email
Reviewer Review Type Date Requested Status
Nigel Babu (community) Approve
Review via email: mp+80849@code.launchpad.net

Commit message

Displays email address on sponsorship review pages.

To post a comment you must log in.
Revision history for this message
Nigel Babu (nigelbabu) wrote :

While this looks to work, it actually doesn't. Summit doesn't store the email ids it gets from Launchpad (can that be done?) This means we don't actually have anyone's email ID.

review: Needs Fixing
Revision history for this message
Nigel Babu (nigelbabu) wrote :

Hrm, this works when I login as myself and apply for sponsorship. But fails, when I nominate someone else for sponsorship. We need to catch that case as well.

Revision history for this message
Nigel Babu (nigelbabu) wrote :

Okay, the nomination can go into a different MP.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/sponsor/templates/sponsor/review.html'
2--- summit/sponsor/templates/sponsor/review.html 2011-08-27 18:05:04 +0000
3+++ summit/sponsor/templates/sponsor/review.html 2011-10-31 21:58:24 +0000
4@@ -7,6 +7,7 @@
5 <h1>{{ sponsorship.user.get_full_name }}</h1>
6
7 <p>
8+{{ sponsorship.user.email }}<br />
9 <a class="launchpad" href="http://launchpad.net/~{{ sponsorship.user.username }}" target="_new"><img src="/media/img/person.png"/>&nbsp;{{ sponsorship.user.username }}</a>
10 <p>
11
12@@ -20,37 +21,6 @@
13 {{ sponsorship.about|escape|urlize|paras }}
14 </p>
15
16-<!--
17-<h3>Brainstorm Ideas</h3>
18-<table class="ideas">
19-<tr><th></th><th>Topic</th><th>Participation</th></tr>
20-{% for idea in ideas %}
21-<tr><td><a href="{{ idea.idea.url }}" target="_new">{{ idea.idea.title }}</a></td>
22- <td>{{ idea.topic.name }}</td>
23- <td>
24- {% ifequal idea.participation "not" %}
25- NOT interested in this idea
26- {% else %}
27- {% ifequal idea.participation "may" %}
28- MAY attend discussions about this idea
29- {% else %}
30- {% ifequal idea.participation "will" %}
31- WILL discuss this idea
32- {% else %}
33- {% ifequal idea.participation "lead" %}
34- will LEAD discussion and development of this idea
35- {% else %}
36- played silly buggers with the form
37- {% endifequal %}
38- {% endifequal %}
39- {% endifequal %}
40- {% endifequal %}
41- </td>
42-</tr>
43-{% endfor %}
44-</table>
45--->
46-
47 <h3>Other</h3>
48 <ul>
49 {% if sponsorship.needs_travel %}

Subscribers

People subscribed via source and target branches