Merge lp:~cjohnston/summit/bad-test-no-donut into lp:summit

Proposed by Chris Johnston
Status: Rejected
Rejected by: Michael Hall
Proposed branch: lp:~cjohnston/summit/bad-test-no-donut
Merge into: lp:summit
Diff against target: 22 lines (+0/-12)
1 file modified
summit/schedule/tests.py (+0/-12)
To merge this branch: bzr merge lp:~cjohnston/summit/bad-test-no-donut
Reviewer Review Type Date Requested Status
Michael Hall (community) Disapprove
Review via email: mp+127162@code.launchpad.net

Commit message

Removes a test that has been made obsolete

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

This test is being kept, with modification, with the new "mark as removed" code

review: Disapprove

Unmerged revisions

449. By Chris Johnston

Removes obsolete test

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/tests.py'
2--- summit/schedule/tests.py 2012-09-09 21:15:17 +0000
3+++ summit/schedule/tests.py 2012-09-30 15:59:21 +0000
4@@ -1745,18 +1745,6 @@
5 summit.update_from_launchpad()
6 self.assertEqual(1, summit.meeting_set.all().count())
7
8- def test_update_from_launchpad_deletes_unseen_meetings(self):
9- summit = factory.make_one(Summit)
10- meeting = summit.meeting_set.create(spec_url='test_url', name="name")
11- def get_sprint_info(url):
12- elem = self.get_basic_launchpad_response()
13- meeting_node = LaunchpadExportNode(name="other")
14- elem.find("unscheduled").add_child("meeting", meeting_node)
15- return elem
16- summit._get_sprint_info_from_launchpad = get_sprint_info
17- summit.update_from_launchpad()
18- self.assertEqual(0, summit.meeting_set.filter(name__exact="name").count())
19-
20 def test_update_from_launchpad_doesnt_delete_meetings_with_no_spec_url(self):
21 summit = factory.make_one(Summit)
22 meeting = summit.meeting_set.create(spec_url='', name="name")

Subscribers

People subscribed via source and target branches