Merge lp:~cjohnston/qa-dashboard/respect-publish into lp:qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 729
Merged at revision: 728
Proposed branch: lp:~cjohnston/qa-dashboard/respect-publish
Merge into: lp:qa-dashboard
Diff against target: 113 lines (+25/-7)
2 files modified
bootspeed/api.py (+16/-4)
bootspeed/views.py (+9/-3)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/respect-publish
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Joe Talbott Approve
Review via email: mp+211592@code.launchpad.net

Commit message

Update bootspeed to only display published data

To post a comment you must log in.
729. By Chris Johnston

Same for views

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:729
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/313/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/313/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bootspeed/api.py'
--- bootspeed/api.py 2013-05-18 00:08:36 +0000
+++ bootspeed/api.py 2014-03-18 17:44:04 +0000
@@ -36,7 +36,11 @@
36def overall(request, arch):36def overall(request, arch):
37 # do some reversed sorting to get the latest images.37 # do some reversed sorting to get the latest images.
38 images = reversed(38 images = reversed(
39 Image.objects.filter(arch=arch, image_type='daily').order_by(39 Image.objects.filter(
40 arch=arch,
41 image_type='daily',
42 publish=True,
43 ).order_by(
40 '-build_number')[:MAX_RESULTS]44 '-build_number')[:MAX_RESULTS]
41 )45 )
4246
@@ -85,7 +89,9 @@
85 res = ImageMachineAgg.objects.filter(89 res = ImageMachineAgg.objects.filter(
86 machine=machine_id,90 machine=machine_id,
87 image__arch=arch,91 image__arch=arch,
88 image__image_type='daily'92 image__image_type='daily',
93 image__publish=True,
94 publish=True,
89 ).order_by(95 ).order_by(
90 'image__build_number'96 'image__build_number'
91 )[:MAX_RESULTS]97 )[:MAX_RESULTS]
@@ -94,6 +100,8 @@
94 machine=machine_id,100 machine=machine_id,
95 image__arch=arch,101 image__arch=arch,
96 image__image_type='release',102 image__image_type='release',
103 image__publish=True,
104 publish=True,
97 ).order_by(105 ).order_by(
98 '-image__build_number'106 '-image__build_number'
99 )107 )
@@ -134,12 +142,16 @@
134 machine=machine_id,142 machine=machine_id,
135 image__arch=arch,143 image__arch=arch,
136 image__image_type='daily',144 image__image_type='daily',
145 image__publish=True,
146 publish=True,
137 ).order_by('image__build_number')[:MAX_RESULTS]147 ).order_by('image__build_number')[:MAX_RESULTS]
138148
139 last_releases = ImageMachineAgg.objects.filter(149 last_releases = ImageMachineAgg.objects.filter(
140 machine=machine_id,150 machine=machine_id,
141 image__arch=arch,151 image__arch=arch,
142 image__image_type='release',152 image__image_type='release',
153 image__publish=True,
154 publish=True,
143 ).order_by('-image__build_number')155 ).order_by('-image__build_number')
144156
145 if last_releases.count() > 0:157 if last_releases.count() > 0:
@@ -227,13 +239,13 @@
227 return JSONResponse(json.dumps(error_data))239 return JSONResponse(json.dumps(error_data))
228240
229 machine = machines[0]241 machine = machines[0]
230 image = Image.objects.filter(md5=md5)242 image = Image.objects.filter(md5=md5, publish=True)
231243
232 if image.count() != 1:244 if image.count() != 1:
233 error_data['message'] = "unknown md5: {}".format(md5)245 error_data['message'] = "unknown md5: {}".format(md5)
234 return JSONResponse(json.dumps(error_data))246 return JSONResponse(json.dumps(error_data))
235247
236 image_results = image.imageresult_set.filter(machine=machine)248 image_results = image.imageresult_set.filter(machine=machine, publish=True)
237249
238 data = json.dumps({250 data = json.dumps({
239 "image_id": image.id,251 "image_id": image.id,
240252
=== modified file 'bootspeed/views.py'
--- bootspeed/views.py 2014-01-07 01:42:37 +0000
+++ bootspeed/views.py 2014-03-18 17:44:04 +0000
@@ -69,7 +69,7 @@
6969
70@require_GET70@require_GET
71def overview(request, release=None):71def overview(request, release=None):
72 images = Image.objects.all()72 images = Image.objects.filter(publish=True)
73 releases = _get_bootspeed_releases()73 releases = _get_bootspeed_releases()
7474
75 if release is not None:75 if release is not None:
@@ -94,7 +94,11 @@
94 if arch is None:94 if arch is None:
95 return redirect('arch/amd64/')95 return redirect('arch/amd64/')
9696
97 result = ImageResult.objects.filter(image__arch=arch).distinct(97 result = ImageResult.objects.filter(
98 image__arch=arch,
99 image__publish=True,
100 publish=True,
101 ).distinct(
98 'machine__name'102 'machine__name'
99 )103 )
100 arches = _get_bootspeed_arches()104 arches = _get_bootspeed_arches()
@@ -154,6 +158,8 @@
154 qs = ImageResult.objects.filter(158 qs = ImageResult.objects.filter(
155 machine__id=machine_id,159 machine__id=machine_id,
156 image__arch=arch,160 image__arch=arch,
161 image__publish=True,
162 publish=True,
157 ).prefetch_related(163 ).prefetch_related(
158 'image',164 'image',
159 'machine',165 'machine',
@@ -204,7 +210,7 @@
204def image_bugs_overview(request):210def image_bugs_overview(request):
205 images = JobImage.objects.annotate(211 images = JobImage.objects.annotate(
206 imagebuild_count=models.Count(212 imagebuild_count=models.Count(
207 'imagebuild'213 'imagebuild',
208 )214 )
209 ).filter(imagebuild_count__gt=0).order_by(215 ).filter(imagebuild_count__gt=0).order_by(
210 '-build_number',216 '-build_number',

Subscribers

People subscribed via source and target branches