Merge lp:~cjohnston/qa-dashboard/rel-path into lp:qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 689
Merged at revision: 690
Proposed branch: lp:~cjohnston/qa-dashboard/rel-path
Merge into: lp:qa-dashboard
Diff against target: 168 lines (+21/-34)
3 files modified
common/static/css/jquery.dataTables.css (+11/-23)
common/static/css/new-style.css (+2/-3)
common/static/css/style.css (+8/-8)
To merge this branch: bzr merge lp:~cjohnston/qa-dashboard/rel-path
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+197369@code.launchpad.net

Commit message

Switch assets to using rel-path

Description of the change

Dashboard plan for charming:

- Add all assets back to lp:qa-dashboard
- Create 'assets' branch for the web team to use to include in assets.u.c (lp:qa-dashboard/assets)
- Create a script to automatically copy staticfiles from lp:qa-dashboard to lp:qa-dashboard/assets when there is an update to assets
- Switch the dashboard to use assets.ubuntu.com for static assets
  * this is the reason for the change in paths in this MP. making the paths relative will cause the site to use the proper assets

Since the assets will be versioned, I will be adding the ability to the script above to update what revision the site needs to look for in assets.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:689
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/263/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/263/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

can you elaborate a little? ie - I think you are doing this because you just moved the assets back into our code-base in plans for a new way to use assets.ubuntu.com. However, maybe sharing the whole plan up-front will allow us to understand if each MP makes sense.

Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'common/static/css/jquery.dataTables.css'
--- common/static/css/jquery.dataTables.css 2013-04-29 17:43:14 +0000
+++ common/static/css/jquery.dataTables.css 2013-12-02 13:46:27 +0000
@@ -1,4 +1,3 @@
1
2/*1/*
3 * Table2 * Table
4 */3 */
@@ -33,17 +32,6 @@
33 text-align: center;32 text-align: center;
34}33}
3534
36/*
37table.dataTable tr.odd { background-color: #E2E4FF; }
38table.dataTable tr.even { background-color: white; }
39
40table.dataTable tr.odd td.sorting_1 { background-color: #D3D6FF; }
41table.dataTable tr.odd td.sorting_2 { background-color: #DADCFF; }
42table.dataTable tr.odd td.sorting_3 { background-color: #E0E2FF; }
43table.dataTable tr.even td.sorting_1 { background-color: #EAEBFF; }
44table.dataTable tr.even td.sorting_2 { background-color: #F2F3FF; }
45table.dataTable tr.even td.sorting_3 { background-color: #F9F9FF; }
46*/
4735
48/*36/*
49 * Table wrapper37 * Table wrapper
@@ -127,13 +115,13 @@
127 margin-left: 10px;115 margin-left: 10px;
128}116}
129117
130.paginate_enabled_previous { background: url('//assets.ubuntu.com/sites/dashboard/img/back_enabled.png') no-repeat top left; }118.paginate_enabled_previous { background: url('../images/back_enabled.png') no-repeat top left; }
131.paginate_enabled_previous:hover { background: url('//assets.ubuntu.com/sites/dashboard/img/back_enabled_hover.png') no-repeat top left; }119.paginate_enabled_previous:hover { background: url('../images/back_enabled_hover.png') no-repeat top left; }
132.paginate_disabled_previous { background: url('//assets.ubuntu.com/sites/dashboard/img/back_disabled.png') no-repeat top left; }120.paginate_disabled_previous { background: url('../images/back_disabled.png') no-repeat top left; }
133121
134.paginate_enabled_next { background: url('//assets.ubuntu.com/sites/dashboard/img/forward_enabled.png') no-repeat top right; }122.paginate_enabled_next { background: url('../images/forward_enabled.png') no-repeat top right; }
135.paginate_enabled_next:hover { background: url('//assets.ubuntu.com/sites/dashboard/img/forward_enabled_hover.png') no-repeat top right; }123.paginate_enabled_next:hover { background: url('../images/forward_enabled_hover.png') no-repeat top right; }
136.paginate_disabled_next { background: url('//assets.ubuntu.com/sites/dashboard/img/forward_disabled.png') no-repeat top right; }124.paginate_disabled_next { background: url('../images/forward_disabled.png') no-repeat top right; }
137125
138/* Full number pagination */126/* Full number pagination */
139.paging_full_numbers {127.paging_full_numbers {
@@ -197,12 +185,12 @@
197/*185/*
198 * Sorting186 * Sorting
199 */187 */
200.sorting { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_both.png') no-repeat center right; }188.sorting { background: url('../images/sort_both.png') no-repeat center right; }
201.sorting_asc { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_asc.png') no-repeat center right; }189.sorting_asc { background: url('../images/sort_asc.png') no-repeat center right; }
202.sorting_desc { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_desc.png') no-repeat center right; }190.sorting_desc { background: url('../images/sort_desc.png') no-repeat center right; }
203191
204.sorting_asc_disabled { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_asc_disabled.png') no-repeat center right; }192.sorting_asc_disabled { background: url('../images/sort_asc_disabled.png') no-repeat center right; }
205.sorting_desc_disabled { background: url('//assets.ubuntu.com/sites/dashboard/img/sort_desc_disabled.png') no-repeat center right; }193.sorting_desc_disabled { background: url('../images/sort_desc_disabled.png') no-repeat center right; }
206 194
207table.dataTable th:active {195table.dataTable th:active {
208 outline: none;196 outline: none;
209197
=== modified file 'common/static/css/new-style.css'
--- common/static/css/new-style.css 2013-10-25 15:37:12 +0000
+++ common/static/css/new-style.css 2013-12-02 13:46:27 +0000
@@ -2,7 +2,7 @@
2 font-size : 100%;2 font-size : 100%;
3}3}
4body {4body {
5 background : url("/static/images/body_bg.jpg") #fff;5 background : url("../images/body_bg.jpg") #fff;
6 color : #333;6 color : #333;
7 font-family : Ubuntu, Arial, "libra sans", sans-serif;7 font-family : Ubuntu, Arial, "libra sans", sans-serif;
8 font-weight : 300;8 font-weight : 300;
@@ -214,7 +214,7 @@
214 margin-left : 20px;214 margin-left : 20px;
215 top : -8px;215 top : -8px;
216 width : 200px;216 width : 200px;
217 background-image : url("/static/images/arrow-up-smaller.png");217 background-image : url("../images/arrow-up-smaller.png");
218}218}
219header.banner .nav-primary li ul li {219header.banner .nav-primary li ul li {
220 border : none 0;220 border : none 0;
@@ -557,4 +557,3 @@
557.clear {557.clear {
558 clear: both;558 clear: both;
559}559}
560
561560
=== modified file 'common/static/css/style.css'
--- common/static/css/style.css 2013-10-25 15:37:12 +0000
+++ common/static/css/style.css 2013-12-02 13:46:27 +0000
@@ -196,13 +196,13 @@
196}196}
197197
198.left_nav li.active {198.left_nav li.active {
199 background: url("//assets.ubuntu.com/sites/dashboard/img/eng_hex.svg") no-repeat;199 background: url("../images/eng_hex.svg") no-repeat;
200 background-size: 16px 16px;200 background-size: 16px 16px;
201 background-position: left;201 background-position: left;
202}202}
203203
204.error-14x14 {204.error-14x14 {
205 background: url("//assets.ubuntu.com/sites/dashboard/img/activity-small-icon-vertical.png") no-repeat;205 background: url("../images/activity-small-icon-vertical.png") no-repeat;
206 background-position:left -14px;206 background-position:left -14px;
207}207}
208208
@@ -379,7 +379,7 @@
379}379}
380380
381div.movement-up {381div.movement-up {
382 background: url("//assets.ubuntu.com/sites/dashboard/img/red-up.svg") no-repeat;382 background: url("../images/red-up.svg") no-repeat;
383 background-size: 20px 20px;383 background-size: 20px 20px;
384 text-indent: -999px;384 text-indent: -999px;
385 width: 100%;385 width: 100%;
@@ -387,7 +387,7 @@
387}387}
388388
389div.movement-down {389div.movement-down {
390 background: url("//assets.ubuntu.com/sites/dashboard/img/green-down.svg") no-repeat;390 background: url("../images/green-down.svg") no-repeat;
391 background-size: 20px 20px;391 background-size: 20px 20px;
392 text-indent: -999px;392 text-indent: -999px;
393 width: 100%;393 width: 100%;
@@ -395,7 +395,7 @@
395}395}
396396
397div.movement-up-inverse {397div.movement-up-inverse {
398 background: url("//assets.ubuntu.com/sites/dashboard/img/green-up.svg") no-repeat;398 background: url("../images/green-up.svg") no-repeat;
399 background-size: 20px 20px;399 background-size: 20px 20px;
400 text-indent: -999px;400 text-indent: -999px;
401 width: 100%;401 width: 100%;
@@ -403,7 +403,7 @@
403}403}
404404
405div.movement-down-inverse {405div.movement-down-inverse {
406 background: url("//assets.ubuntu.com/sites/dashboard/img/red-down.svg") no-repeat;406 background: url("../images/red-down.svg") no-repeat;
407 background-size: 20px 20px;407 background-size: 20px 20px;
408 text-indent: -999px;408 text-indent: -999px;
409 width: 100%;409 width: 100%;
@@ -482,7 +482,7 @@
482}482}
483483
484div.help {484div.help {
485 background: url("//assets.ubuntu.com/sites/dashboard/img/help.svg") no-repeat;485 background: url("../images/help.svg") no-repeat;
486 background-size: 24px 24px;486 background-size: 24px 24px;
487 text-indent: -999px;487 text-indent: -999px;
488 display: inline-block;488 display: inline-block;
@@ -590,7 +590,7 @@
590}590}
591591
592.list-ubuntu li {592.list-ubuntu li {
593 background-image: url("//assets.ubuntu.com/sites/ubuntu/latest/u/img/patterns/tick-orange.png");593 background-image: url("../images/tick-orange.png");
594}594}
595 595
596ul.artifacts {596ul.artifacts {
597597
=== added file 'common/static/images/tick-orange.png'
598Binary files common/static/images/tick-orange.png 1970-01-01 00:00:00 +0000 and common/static/images/tick-orange.png 2013-12-02 13:46:27 +0000 differ598Binary files common/static/images/tick-orange.png 1970-01-01 00:00:00 +0000 and common/static/images/tick-orange.png 2013-12-02 13:46:27 +0000 differ

Subscribers

People subscribed via source and target branches