Code review comment for lp:~cjohnston/launchpad/short-ic-emails

Revision history for this message
William Grant (wgrant) wrote :

Line numbers jump ahead by one at the boundary between file, as visible in expected-6: the comment in the second file is rendered a line too late, and the comment in the third is two lines late. I assume the trailing newline isn't being counted.

Also, it probably makes sense to have a gap between hunks, at least when one is skipped. In expected-6, the hunk at 70 seems to lead directly into 88, but in the original there's one at 80.

Additionally, does expected-1 give any value over expected-6?

review: Needs Fixing (code)

« Back to merge proposal