Code review comment for lp:~cjohnston/launchpad/short-ic-emails

Revision history for this message
Celso Providelo (cprov) wrote :

lib/lp/services/patches.py is a much better place, the code style there still alien to LP, it reads very differently. But I am not opposed to landing it this way if you think it will be closer to the original bzrlib, thus easier to maintain up to date.

Looks good for landing and get some feedback from users, possibly experimenting with including previous comments too.

Good work!

review: Approve

« Back to merge proposal