Launchpad itself

Code review comment for lp:~cjohnston/launchpad/ic-approx-time

  1. ic-approx-time
  2. Merge into devel
Revision history for this message
William Grant (wgrant) wrote :

Date.now and the ISO 8601 support in Date.parse are relatively new, and we probably want to fall back if they don't work. This will fail at least in IE8, and quite possibly on the Lucid buildbots which use an old WebKit. We probably don't care about IE8 at this point, but buildbot will be a problem.

Also, your bzr whoami is wrong; consider correcting it and recommitting.

And there are a few comments inline.

review: Needs Fixing (code)

« Back to merge proposal