Merge lp:~cjohnston/launchpad/bBAB-bCA into lp:launchpad

Proposed by Chris Johnston
Status: Merged
Merged at revision: 17026
Proposed branch: lp:~cjohnston/launchpad/bBAB-bCA
Merge into: lp:launchpad
Diff against target: 56 lines (+5/-5)
4 files modified
lib/canonical/launchpad/icing/style.css (+2/-2)
lib/lp/bugs/templates/bugcomment-macros.pt (+1/-1)
lib/lp/code/stories/branches/xx-code-review-comments.txt (+1/-1)
lib/lp/services/comments/templates/comment.pt (+1/-1)
To merge this branch: bzr merge lp:~cjohnston/launchpad/bBAB-bCA
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+221325@code.launchpad.net

Commit message

Rename boardBugActivityBody to boardCommentActivity as it is now used in places other than bugs

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css 2014-05-28 21:17:40 +0000
+++ lib/canonical/launchpad/icing/style.css 2014-05-29 07:44:00 +0000
@@ -238,11 +238,11 @@
238 border-left: 1px solid #ddd;238 border-left: 1px solid #ddd;
239}239}
240.boardCommentBody {padding: 0.5em 12px 0;}240.boardCommentBody {padding: 0.5em 12px 0;}
241.boardBugActivityBody {241.boardCommentActivity {
242 padding: 0.5em 12px;242 padding: 0.5em 12px;
243 background-color: #fafafa;243 background-color: #fafafa;
244}244}
245.boardBugActivityBody table {245.boardCommentActivity table {
246 margin-bottom: 0.5em;246 margin-bottom: 0.5em;
247 margin-top: 0.5em;247 margin-top: 0.5em;
248}248}
249249
=== modified file 'lib/lp/bugs/templates/bugcomment-macros.pt'
--- lib/lp/bugs/templates/bugcomment-macros.pt 2012-09-21 02:51:51 +0000
+++ lib/lp/bugs/templates/bugcomment-macros.pt 2014-05-29 07:44:00 +0000
@@ -40,7 +40,7 @@
40 7 minutes ago40 7 minutes ago
41 </span>41 </span>
42 </div>42 </div>
43 <div class="boardBugActivityBody">43 <div class="boardCommentActivity">
44 <metal:activity-table44 <metal:activity-table
45 metal:use-macro="context/@@bugcomment-macros/activity-table" />45 metal:use-macro="context/@@bugcomment-macros/activity-table" />
46 </div>46 </div>
4747
=== modified file 'lib/lp/code/stories/branches/xx-code-review-comments.txt'
--- lib/lp/code/stories/branches/xx-code-review-comments.txt 2014-05-29 07:08:17 +0000
+++ lib/lp/code/stories/branches/xx-code-review-comments.txt 2014-05-29 07:44:00 +0000
@@ -132,7 +132,7 @@
132132
133 >>> print_comments('boardCommentDetails', eric_browser, index=2)133 >>> print_comments('boardCommentDetails', eric_browser, index=2)
134 Eric the Viking ... ago: #134 Eric the Viking ... ago: #
135 >>> print_comments('boardBugActivityBody', eric_browser, index=0)135 >>> print_comments('boardCommentActivity', eric_browser, index=0)
136 review: Abstain (timeless)136 review: Abstain (timeless)
137 >>> print_comments('boardCommentBody', eric_browser, index=2)137 >>> print_comments('boardCommentBody', eric_browser, index=2)
138138
139139
=== modified file 'lib/lp/services/comments/templates/comment.pt'
--- lib/lp/services/comments/templates/comment.pt 2014-05-29 07:08:17 +0000
+++ lib/lp/services/comments/templates/comment.pt 2014-05-29 07:44:00 +0000
@@ -17,7 +17,7 @@
17 tal:content="structure context/@@+comment-body">17 tal:content="structure context/@@+comment-body">
18 The comment body18 The comment body
19 </div>19 </div>
20 <div class="boardBugActivityBody"20 <div class="boardCommentActivity"
21 tal:condition="context/has_footer"21 tal:condition="context/has_footer"
22 tal:content="structure context/@@+comment-footer">22 tal:content="structure context/@@+comment-footer">
23 Activity or other footer details.23 Activity or other footer details.