Merge lp:~cjohnston/launchpad/627628 into lp:launchpad

Proposed by Chris Johnston
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 13071
Proposed branch: lp:~cjohnston/launchpad/627628
Merge into: lp:launchpad
Diff against target: 33 lines (+3/-3)
2 files modified
lib/lp/answers/browser/question.py (+1/-1)
lib/lp/answers/stories/question-workflow.txt (+2/-2)
To merge this branch: bzr merge lp:~cjohnston/launchpad/627628
Reviewer Review Type Date Requested Status
Henning Eggers (community) Approve
Review via email: mp+61055@code.launchpad.net

Commit message

[r=henninge][bug=627628] Changes the "Add Answer" to "Propose Answer" as proposing an answer better describes the act.

To post a comment you must log in.
Revision history for this message
Henning Eggers (henninge) wrote :

Thank you. ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/answers/browser/question.py'
2--- lib/lp/answers/browser/question.py 2011-05-11 10:49:45 +0000
3+++ lib/lp/answers/browser/question.py 2011-05-16 11:42:36 +0000
4@@ -924,7 +924,7 @@
5 self.user != self.context.owner and
6 self.context.can_give_answer)
7
8- @action(_('Add Answer'), name='answer', condition=canAddAnswer)
9+ @action(_('Propose Answer'), name='answer', condition=canAddAnswer)
10 def answer_action(self, action, data):
11 """Add an answer to the question."""
12 self.context.giveAnswer(self.user, data['message'])
13
14=== modified file 'lib/lp/answers/stories/question-workflow.txt'
15--- lib/lp/answers/stories/question-workflow.txt 2009-11-14 21:48:41 +0000
16+++ lib/lp/answers/stories/question-workflow.txt 2011-05-16 11:42:36 +0000
17@@ -139,14 +139,14 @@
18
19 Once the question is clarified, it is easier for a user to give an
20 answer. This is done by entering the answer in the 'Message' box
21-and clicking the 'Add Answer' button.
22+and clicking the 'Propose Answer' button.
23
24 >>> support_browser.open(
25 ... 'http://launchpad.dev/firefox/+question/2')
26 >>> support_browser.getControl('Message').value = (
27 ... "New version of the firefox package are available with SVG "
28 ... "support enabled. You can use apt-get or adept to upgrade.")
29- >>> support_browser.getControl('Add Answer').click()
30+ >>> support_browser.getControl('Propose Answer').click()
31
32 This moves the the question to the Answered state and adds the
33 answer to the end of the discussion: