Merge ~cjohnston/charm-telegraf:lp2016430 into charm-telegraf:master

Proposed by Chris Johnston
Status: Merged
Approved by: Ramesh Sattaru
Approved revision: 9a327929c307042da209a82559238954ea9b3720
Merged at revision: 8daf9839c74bedf7bec0bcfb1eeeda80c094436a
Proposed branch: ~cjohnston/charm-telegraf:lp2016430
Merge into: charm-telegraf:master
Diff against target: 27 lines (+4/-1)
2 files modified
src/reactive/telegraf.py (+2/-1)
src/tests/functional/tests/bundles/base-snap.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
Eric Chen Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+441146@code.launchpad.net

Commit message

Don't require telegraf package on snap install.

LP: #2016430

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Eric Chen (eric-chen) wrote :

LGTM

review: Approve
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 8daf9839c74bedf7bec0bcfb1eeeda80c094436a

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/reactive/telegraf.py b/src/reactive/telegraf.py
index 8f88df8..6189fa3 100644
--- a/src/reactive/telegraf.py
+++ b/src/reactive/telegraf.py
@@ -972,7 +972,8 @@ def install_telegraf():
972 pass972 pass
973 apt.queue_install(["telegraf"])973 apt.queue_install(["telegraf"])
974 elif install_method == "snap":974 elif install_method == "snap":
975 apt.purge("telegraf")975 if fetch.get_installed_version("telegraf"):
976 apt.purge("telegraf")
976 config = hookenv.config()977 config = hookenv.config()
977 snap_channel = config.get("snap_channel")978 snap_channel = config.get("snap_channel")
978 snap.install("telegraf", channel=snap_channel, classic=True)979 snap.install("telegraf", channel=snap_channel, classic=True)
diff --git a/src/tests/functional/tests/bundles/base-snap.yaml b/src/tests/functional/tests/bundles/base-snap.yaml
index 139ab02..6213696 100644
--- a/src/tests/functional/tests/bundles/base-snap.yaml
+++ b/src/tests/functional/tests/bundles/base-snap.yaml
@@ -3,6 +3,8 @@ applications:
3 num_units: 03 num_units: 0
4 options:4 options:
5 install_method: 'snap'5 install_method: 'snap'
6 install_sources: ''
7 install_keys: ''
6 ubuntu:8 ubuntu:
7 charm: ch:ubuntu9 charm: ch:ubuntu
8 num_units: 110 num_units: 1

Subscribers

People subscribed via source and target branches

to all changes: