Merge lp:~cjcurran/indicator-sound/lp-992262-fix into lp:indicator-sound/12.10

Proposed by Conor Curran
Status: Merged
Approved by: Charles Kerr
Approved revision: 325
Merged at revision: 325
Proposed branch: lp:~cjcurran/indicator-sound/lp-992262-fix
Merge into: lp:indicator-sound/12.10
Diff against target: 39 lines (+5/-6)
1 file modified
src/music-player-bridge.vala (+5/-6)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/lp-992262-fix
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+104626@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/music-player-bridge.vala'
--- src/music-player-bridge.vala 2012-03-27 01:33:40 +0000
+++ src/music-player-bridge.vala 2012-05-03 21:12:20 +0000
@@ -163,7 +163,6 @@
163 }163 }
164 164
165 var mpris_key = determine_key ( desktop );165 var mpris_key = determine_key ( desktop );
166 // Are we sure clients will appear like this with the new registration method in place.
167 if ( this.registered_clients.has_key (mpris_key) == false ){166 if ( this.registered_clients.has_key (mpris_key) == false ){
168 debug("New client has registered that we have not seen before: %s", dbus_name );167 debug("New client has registered that we have not seen before: %s", dbus_name );
169 PlayerController ctrl = new PlayerController ( this.root_menu,168 PlayerController ctrl = new PlayerController ( this.root_menu,
@@ -189,14 +188,14 @@
189 188
190 public void client_has_vanished ( string mpris_root_interface )189 public void client_has_vanished ( string mpris_root_interface )
191 {190 {
192 debug("MusicPlayerBridge -> client with dbus interface %s has vanished",191 debug("\n MusicPlayerBridge -> client with dbus interface %s has vanished",
193 mpris_root_interface );192 mpris_root_interface );
194 if (root_menu != null){193 if (root_menu != null){
195 debug("attempt to remove %s", mpris_root_interface);194 debug("\n attempt to remove %s", mpris_root_interface);
196 var mpris_key = determine_key ( mpris_root_interface );195 var mpris_key = determine_key ( mpris_root_interface );
197 if ( mpris_key != null && this.registered_clients.has_key(mpris_key)){196 if ( mpris_key != null && this.registered_clients.has_key(mpris_key)){
198 registered_clients[mpris_key].hibernate();197 registered_clients[mpris_key].hibernate();
199 debug("Successively offlined client %s", mpris_key); 198 debug("\n Successively offlined client %s", mpris_key);
200 }199 }
201 }200 }
202 }201 }
@@ -286,8 +285,8 @@
286 }285 }
287 var temp = result.split("-");286 var temp = result.split("-");
288 if (temp != null && temp.length > 1){287 if (temp != null && temp.length > 1){
289 result = temp[0];288 result = temp[1];
290 }289 }
291 return result; 290 return result;
292 }291 }
293 292

Subscribers

People subscribed via source and target branches