Merge lp:~cjcurran/indicator-sound/localise-vala-files into lp:~indicator-applet-developers/indicator-sound/trunk_3

Proposed by Conor Curran
Status: Merged
Merged at revision: 225
Proposed branch: lp:~cjcurran/indicator-sound/localise-vala-files
Merge into: lp:~indicator-applet-developers/indicator-sound/trunk_3
Diff against target: 165 lines (+34/-15)
7 files modified
Makefile.am (+4/-1)
po/POTFILES.in (+1/-0)
src/Makefile.am (+8/-8)
src/common-defs.h (+3/-0)
src/playlists-menu-item.vala (+7/-3)
src/sound-service.c (+3/-3)
vapi/config.vapi (+8/-0)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/localise-vala-files
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
David Barth Approve
Review via email: mp+53849@code.launchpad.net

Description of the change

fixes bug attached

To post a comment you must log in.
Revision history for this message
David Barth (dbarth) wrote :

Builds here. I trust you for the t10n calls themselves

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

you need to list playlists-menu-item in POTFILES.in as well to get it translated

review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

ignore that, I can't read today it seems ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile.am'
--- Makefile.am 2011-01-27 03:09:45 +0000
+++ Makefile.am 2011-03-17 16:17:30 +0000
@@ -4,7 +4,10 @@
4 data \4 data \
5 po5 po
66
7EXTRA_DIST = autogen.sh vapi/common-defs.vapi7EXTRA_DIST = \
8 autogen.sh \
9 vapi/common-defs.vapi \
10 vapi/config.vapi
811
9DISTCHECK_CONFIGURE_FLAGS = --enable-localinstall12DISTCHECK_CONFIGURE_FLAGS = --enable-localinstall
1013
1114
=== modified file 'po/POTFILES.in'
--- po/POTFILES.in 2011-02-22 00:32:51 +0000
+++ po/POTFILES.in 2011-03-17 16:17:30 +0000
@@ -2,3 +2,4 @@
2src/indicator-sound.c2src/indicator-sound.c
3src/mute-menu-item.c3src/mute-menu-item.c
4src/sound-service-dbus.c4src/sound-service-dbus.c
5src/playlists-menu-item.c
56
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2011-03-14 19:47:59 +0000
+++ src/Makefile.am 2011-03-17 16:17:30 +0000
@@ -56,8 +56,7 @@
56 settings-manager.vala \56 settings-manager.vala \
57 playlists-menu-item.vala \57 playlists-menu-item.vala \
58 freedesktop-interfaces.vala \58 freedesktop-interfaces.vala \
59 fetch-file.vala59 fetch-file.vala
60
6160
62music_bridge_VALAFLAGS = \61music_bridge_VALAFLAGS = \
63 --ccode \62 --ccode \
@@ -69,10 +68,11 @@
69 --pkg gee-1.0 \68 --pkg gee-1.0 \
70 --pkg Dbusmenu-0.4 \69 --pkg Dbusmenu-0.4 \
71 --pkg common-defs \70 --pkg common-defs \
72 --pkg gio-2.0 \71 --pkg config \
73 --pkg gio-unix-2.0 \72 --pkg gio-2.0 \
74 --pkg gdk-pixbuf-2.0 \73 --pkg gio-unix-2.0 \
75 --pkg libxml-2.074 --pkg gdk-pixbuf-2.0 \
75 --pkg libxml-2.0
7676
77 $(MAINTAINER_VALAFLAGS)77 $(MAINTAINER_VALAFLAGS)
7878
@@ -137,10 +137,10 @@
137#######################137#######################
138BUILT_SOURCES = \138BUILT_SOURCES = \
139 music_bridge_vala.stamp \139 music_bridge_vala.stamp \
140 $(music_bridge_APIFILES) \140 $(music_bridge_APIFILES) \
141 gen-sound-service.xml.h \141 gen-sound-service.xml.h \
142 gen-sound-service.xml.c \142 gen-sound-service.xml.c \
143 $(music_bridge_VALASOURCES:.vala=.c)143 $(music_bridge_VALASOURCES:.vala=.c)
144 144
145CLEANFILES = \145CLEANFILES = \
146 $(BUILT_SOURCES)146 $(BUILT_SOURCES)
147147
=== modified file 'src/common-defs.h'
--- src/common-defs.h 2011-03-15 12:22:21 +0000
+++ src/common-defs.h 2011-03-17 16:17:30 +0000
@@ -19,6 +19,9 @@
19#ifndef __COMMON_DEFS_H__19#ifndef __COMMON_DEFS_H__
20#define __COMMON_DEFS_H__20#define __COMMON_DEFS_H__
2121
22#ifdef HAVE_CONFIG_H
23#include "config.h"
24#endif
2225
23typedef enum {26typedef enum {
24 MUTED,27 MUTED,
2528
=== modified file 'src/playlists-menu-item.vala'
--- src/playlists-menu-item.vala 2011-03-11 16:33:04 +0000
+++ src/playlists-menu-item.vala 2011-03-17 16:17:30 +0000
@@ -17,11 +17,13 @@
17with this program. If not, see <http://www.gnu.org/licenses/>.17with this program. If not, see <http://www.gnu.org/licenses/>.
18*/18*/
1919
20using Config;
20using Dbusmenu;21using Dbusmenu;
21using DbusmenuPlaylists;22using DbusmenuPlaylists;
22using DbusmenuPlaylist;23using DbusmenuPlaylist;
23using Gee;24using Gee;
2425
26
25public class PlaylistsMenuitem : PlayerItem27public class PlaylistsMenuitem : PlayerItem
26{28{
27 private HashMap<int, Dbusmenu.Menuitem> current_playlists; 29 private HashMap<int, Dbusmenu.Menuitem> current_playlists;
@@ -31,12 +33,14 @@
31 {33 {
32 Object ( item_type: MENUITEM_TYPE, owner: parent );34 Object ( item_type: MENUITEM_TYPE, owner: parent );
33 }35 }
36
34 construct{37 construct{
35 this.current_playlists = new HashMap<int, Dbusmenu.Menuitem>();38 this.current_playlists = new HashMap<int, Dbusmenu.Menuitem>();
36 this.root_item = new Menuitem();39 this.root_item = new Menuitem();
3740
38 this.root_item.property_set ( MENUITEM_PROP_LABEL, "Choose Playlist" );41 this.root_item.property_set ( MENUITEM_PROP_LABEL, _("Choose Playlist") );
39 this.root_item.property_set ( MENUITEM_PATH, "" );42 this.root_item.property_set ( MENUITEM_PATH, "" );
43
40 }44 }
4145
42 public new void update (PlaylistDetails[] playlists)46 public new void update (PlaylistDetails[] playlists)
@@ -74,7 +78,7 @@
74 }78 }
75 if (within == false){79 if (within == false){
76 if (this.root_item.property_get (MENUITEM_PATH) == item.property_get (MENUITEM_PATH)){80 if (this.root_item.property_get (MENUITEM_PATH) == item.property_get (MENUITEM_PATH)){
77 this.root_item.property_set (MENUITEM_PROP_LABEL, "Choose Playlist"); 81 this.root_item.property_set (MENUITEM_PROP_LABEL, _("Choose Playlist"));
78 }82 }
79 this.root_item.child_delete (item); 83 this.root_item.child_delete (item);
80 }84 }
@@ -118,7 +122,7 @@
118 public void active_playlist_update (PlaylistDetails detail)122 public void active_playlist_update (PlaylistDetails detail)
119 {123 {
120 var update = detail.name; 124 var update = detail.name;
121 if ( update == "" ) update = "Choose Playlist";125 if ( update == "" ) update = _("Choose Playlist");
122 this.root_item.property_set (MENUITEM_PROP_LABEL, update); 126 this.root_item.property_set (MENUITEM_PROP_LABEL, update);
123 this.root_item.property_set (MENUITEM_PATH, detail.path); 127 this.root_item.property_set (MENUITEM_PATH, detail.path);
124 }128 }
125129
=== modified file 'src/sound-service.c'
--- src/sound-service.c 2011-03-16 12:38:04 +0000
+++ src/sound-service.c 2011-03-17 16:17:30 +0000
@@ -51,11 +51,11 @@
51int51int
52main (int argc, char ** argv)52main (int argc, char ** argv)
53{53{
54
54 g_type_init();55 g_type_init();
5556 textdomain (GETTEXT_PACKAGE);
57 bindtextdomain (GETTEXT_PACKAGE, GNOMELOCALEDIR);
56 setlocale (LC_ALL, "");58 setlocale (LC_ALL, "");
57 bindtextdomain (GETTEXT_PACKAGE, GNOMELOCALEDIR);
58 textdomain (GETTEXT_PACKAGE);
5959
60 IndicatorService *service = indicator_service_new_version(INDICATOR_SOUND_DBUS_NAME,60 IndicatorService *service = indicator_service_new_version(INDICATOR_SOUND_DBUS_NAME,
61 INDICATOR_SOUND_DBUS_VERSION);61 INDICATOR_SOUND_DBUS_VERSION);
6262
=== added file 'vapi/config.vapi'
--- vapi/config.vapi 1970-01-01 00:00:00 +0000
+++ vapi/config.vapi 2011-03-17 16:17:30 +0000
@@ -0,0 +1,8 @@
1[CCode (cprefix = "", lower_case_cprefix = "", cheader_filename = "../config.h")]
2namespace Config {
3 public const string GETTEXT_PACKAGE;
4 public const string LOCALEDIR;
5 public const string PKGDATADIR;
6 public const string PACKAGE_NAME;
7 public const string PACKAGE_VERSION;
8}

Subscribers

People subscribed via source and target branches