Merge lp:~cjcurran/indicator-sound/hover-regression into lp:indicator-sound/sound-menu-v2

Proposed by Conor Curran
Status: Merged
Merged at revision: 153
Proposed branch: lp:~cjcurran/indicator-sound/hover-regression
Merge into: lp:indicator-sound/sound-menu-v2
Diff against target: 103 lines (+17/-18)
1 file modified
src/transport-widget.c (+17/-18)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/hover-regression
Reviewer Review Type Date Requested Status
Kalle Valo (community) Approve
Review via email: mp+40008@code.launchpad.net

Description of the change

Fixes attached bug.

To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/transport-widget.c'
--- src/transport-widget.c 2010-10-26 21:03:20 +0000
+++ src/transport-widget.c 2010-11-03 19:23:41 +0000
@@ -114,7 +114,7 @@
114 gpointer userdata );114 gpointer userdata );
115static void transport_widget_menu_hidden ( GtkWidget *menu,115static void transport_widget_menu_hidden ( GtkWidget *menu,
116 TransportWidget *transport);116 TransportWidget *transport);
117static void transport_widget_notify ( TransportWidget *item,117static void transport_widget_notify ( GObject *item,
118 GParamSpec *pspec,118 GParamSpec *pspec,
119 gpointer user_data );119 gpointer user_data );
120120
@@ -135,12 +135,12 @@
135135
136 g_type_class_add_private (klass, sizeof (TransportWidgetPrivate));136 g_type_class_add_private (klass, sizeof (TransportWidgetPrivate));
137137
138 widget_class->button_press_event = transport_widget_button_press_event;138 widget_class->button_press_event = transport_widget_button_press_event;
139 widget_class->button_release_event = transport_widget_button_release_event; 139 widget_class->button_release_event = transport_widget_button_release_event;
140 widget_class->expose_event = transport_widget_expose;140 widget_class->expose_event = transport_widget_expose;
141 141
142 gobject_class->dispose = transport_widget_dispose;142 gobject_class->dispose = transport_widget_dispose;
143 gobject_class->finalize = transport_widget_finalize;143 gobject_class->finalize = transport_widget_finalize;
144}144}
145145
146static void146static void
@@ -158,9 +158,9 @@
158 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(5), 1);158 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(5), 1);
159 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(60), 2);159 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(60), 2);
160 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(34), 3);160 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(34), 3);
161 g_hash_table_insert(priv->command_coordinates,161 g_hash_table_insert(priv->command_coordinates,
162 GINT_TO_POINTER(TRANSPORT_PREVIOUS),162 GINT_TO_POINTER(TRANSPORT_PREVIOUS),
163 previous_list);163 previous_list);
164 164
165 GList* play_list = NULL;165 GList* play_list = NULL;
166 play_list = g_list_insert(play_list, GINT_TO_POINTER(58), 0);166 play_list = g_list_insert(play_list, GINT_TO_POINTER(58), 0);
@@ -183,10 +183,10 @@
183 next_list);183 next_list);
184 184
185 gtk_widget_set_size_request(GTK_WIDGET(self), 200, 50);185 gtk_widget_set_size_request(GTK_WIDGET(self), 200, 50);
186 g_signal_connect (G_OBJECT(self),186 g_signal_connect (G_OBJECT(self),
187 "notify::parent",187 "notify",
188 G_CALLBACK (transport_widget_notify),188 G_CALLBACK (transport_widget_notify),
189 NULL); 189 NULL);
190}190}
191191
192static void192static void
@@ -213,7 +213,7 @@
213 event->area.width, event->area.height);213 event->area.width, event->area.height);
214214
215 cairo_clip(cr);215 cairo_clip(cr);
216 draw (button, cr);216 draw (button, cr);
217217
218 cairo_destroy (cr);218 cairo_destroy (cr);
219 return FALSE;219 return FALSE;
@@ -230,16 +230,16 @@
230}230}
231231
232static void232static void
233transport_widget_notify (TransportWidget *item,233transport_widget_notify ( GObject *item,
234 GParamSpec *pspec,234 GParamSpec *pspec,
235 gpointer user_data)235 gpointer user_data )
236{236{
237 if (g_strcmp0 (pspec->name, "parent")){237 if (g_strcmp0 (pspec->name, "parent")){
238 GtkWidget *parent = gtk_widget_get_parent (GTK_WIDGET (item));238 GtkWidget *parent = gtk_widget_get_parent (GTK_WIDGET (item));
239 if (parent){239 if (parent){
240 g_signal_connect ( parent, "hide",240 g_signal_connect ( parent, "hide",
241 G_CALLBACK (transport_widget_menu_hidden),241 G_CALLBACK (transport_widget_menu_hidden),
242 item);242 item );
243 }243 }
244 }244 }
245}245}
@@ -248,7 +248,6 @@
248transport_widget_menu_hidden ( GtkWidget *menu,248transport_widget_menu_hidden ( GtkWidget *menu,
249 TransportWidget *transport)249 TransportWidget *transport)
250{250{
251 //g_debug("Transport Widget's menu hidden method called");
252 g_return_if_fail(IS_TRANSPORT_WIDGET(transport));251 g_return_if_fail(IS_TRANSPORT_WIDGET(transport));
253 transport_widget_react_to_button_release(transport, TRANSPORT_NADA); 252 transport_widget_react_to_button_release(transport, TRANSPORT_NADA);
254}253}
@@ -1274,7 +1273,7 @@
1274 G_CALLBACK(transport_widget_property_update), self);1273 G_CALLBACK(transport_widget_property_update), self);
1275 gint initial_state = dbusmenu_menuitem_property_get_int( twin_item,1274 gint initial_state = dbusmenu_menuitem_property_get_int( twin_item,
1276 DBUSMENU_TRANSPORT_MENUITEM_PLAY_STATE );1275 DBUSMENU_TRANSPORT_MENUITEM_PLAY_STATE );
1277 g_debug("TRANSPORT WIDGET - INITIAL UPDATE = %i", initial_state);1276 //g_debug("TRANSPORT WIDGET - INITIAL UPDATE = %i", initial_state);
1278 transport_widget_toggle_play_pause( self,1277 transport_widget_toggle_play_pause( self,
1279 (TransportWidgetState)initial_state); 1278 (TransportWidgetState)initial_state);
1280}1279}

Subscribers

People subscribed via source and target branches

to all changes: