Merge lp:~cjcurran/indicator-sound/fix-lp-902715 into lp:indicator-sound/12.10

Proposed by Conor Curran
Status: Merged
Approved by: Charles Kerr
Approved revision: 328
Merged at revision: 324
Proposed branch: lp:~cjcurran/indicator-sound/fix-lp-902715
Merge into: lp:indicator-sound/12.10
Diff against target: 49 lines (+22/-3)
1 file modified
src/volume-widget.c (+22/-3)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/fix-lp-902715
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Review via email: mp+103399@code.launchpad.net

Description of the change

Luke said to go ahead and release with the fix in this branch. We can delve deeper when there is a chance later next month.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

This patch is still incomplete, but you're aware of that and this patch does improve the problem in Bug #902715.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/volume-widget.c'
--- src/volume-widget.c 2012-03-17 00:37:32 +0000
+++ src/volume-widget.c 2012-04-25 01:04:26 +0000
@@ -135,16 +135,28 @@
135135
136 if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_LEVEL, property) == 0){136 if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_LEVEL, property) == 0){
137 g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_DOUBLE) );137 g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_DOUBLE) );
138 gdouble update = g_variant_get_double (value);
139
138 if(priv->grabbed == FALSE){140 if(priv->grabbed == FALSE){
139 GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider);141 GtkWidget *slider = ido_scale_menu_item_get_scale((IdoScaleMenuItem*)priv->ido_volume_slider);
140 GtkRange *range = (GtkRange*)slider;142 GtkRange *range = (GtkRange*)slider;
141 gdouble update = g_variant_get_double (value);
142 gtk_range_set_value(range, update);143 gtk_range_set_value(range, update);
143/*144/*
144 g_debug ("volume-widget::volume_widget_property_update - volume - value %f", update);145 g_debug ("volume-widget::volume_widget_property_update - volume - value %f", update);
145*/146 AtkObject* atk_object;
146 update_accessible_desc(priv->indicator);147 atk_object = gtk_widget_get_accessible (priv->ido_volume_slider);
148 if (atk_object != NULL){
149 atk_object_set_name (atk_object, desc);
150
151 }*/
147 }152 }
153 gchar* desc = g_strdup_printf(_("Volume (%'.0f%%)"),
154 update);
155 dbusmenu_menuitem_property_set (priv->twin_item,
156 DBUSMENU_MENUITEM_PROP_ACCESSIBLE_DESC,
157 desc);
158 g_free (desc);
159 update_accessible_desc(priv->indicator);
148 }160 }
149 else if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_MUTE, property) == 0){161 else if(g_ascii_strcasecmp(DBUSMENU_VOLUME_MENUITEM_MUTE, property) == 0){
150 g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN));162 g_return_if_fail (g_variant_is_of_type (value, G_VARIANT_TYPE_BOOLEAN));
@@ -196,6 +208,13 @@
196 initial_level = 0;208 initial_level = 0;
197 }209 }
198 gtk_range_set_value(range, initial_level);210 gtk_range_set_value(range, initial_level);
211 gchar* desc = g_strdup_printf(_("Volume (%'.0f%%)"),
212 initial_level);
213 dbusmenu_menuitem_property_set (priv->twin_item,
214 DBUSMENU_MENUITEM_PROP_ACCESSIBLE_DESC,
215 desc);
216 g_free (desc);
217
199}218}
200219
201static gboolean220static gboolean

Subscribers

People subscribed via source and target branches