Merge lp:~cjcurran/friends/call-contacts-at-startup into lp:friends

[Conor Curran]

[Robert Bruce Park (robru)]

Dropped contact stubs and added test coverage, merged.

review: Approve

=== modified file 'friends/protocols/facebook.py'
--- friends/protocols/facebook.py	2012-11-06 16:05:25 +0000
+++ friends/protocols/facebook.py	2012-11-15 17:40:29 +0000
@@ -330,6 +330,11 @@
         vcaws_param = EBook.VCardAttributeParam.new('jabber')
         vcaws_param.add_value('-{}@chat.facebook.com'.format(user_id))
         vcaws.add_param(vcaws_param)
+
+        vcaws_param_2 = EBook.VCardAttributeParam.new('alias')
+        vcaws_param_2.add_value(user_fullname)
+        vcaws.add_param(vcaws_param_2)
+
         vcard.add_attribute(vcaws)
 
         if gender is not None:
 
=== modified file 'friends/protocols/flickr.py'
--- friends/protocols/flickr.py	2012-11-06 17:40:41 +0000
+++ friends/protocols/flickr.py	2012-11-15 17:40:29 +0000
@@ -120,3 +120,8 @@
                 img_url=img_url,
                 img_src=img_src,
                 img_thumb=img_thumb)
+
+    @feature
+    def contacts(self):
+        pass
+
 
=== modified file 'friends/protocols/foursquare.py'
--- friends/protocols/foursquare.py	2012-11-06 16:05:25 +0000
+++ friends/protocols/foursquare.py	2012-11-15 17:40:29 +0000
@@ -97,3 +97,7 @@
                 url=CHECKIN_URL.format(access_token=token,
                                        checkin_id=checkin_id),
                 )
+
+    @feature
+    def contacts(self):
+        pass
 
=== modified file 'friends/protocols/identica.py'
--- friends/protocols/identica.py	2012-10-25 05:06:23 +0000
+++ friends/protocols/identica.py	2012-11-15 17:40:29 +0000
@@ -71,3 +71,7 @@
         useless. Just use search() instead.
         """
         raise NotImplementedError
+
+    def contacts(self):
+        pass
+
 
=== modified file 'friends/protocols/twitter.py'
--- friends/protocols/twitter.py	2012-11-06 16:05:25 +0000
+++ friends/protocols/twitter.py	2012-11-15 17:40:29 +0000
@@ -296,6 +296,11 @@
         for tweet in response.get(self._search_result_key, []):
             self._publish_tweet(tweet, stream='search/{}'.format(query))
 
+    @feature
+    def contacts(self):
+        pass
+
+
 
 class RateLimiter(BaseRateLimiter):
     """Twitter rate limiter."""
@@ -335,3 +340,4 @@
             else:
                 wait_secs = rate_delta / rate_count
                 self._limits[url] = wait_secs
+
 
=== modified file 'friends/service/dispatcher.py'
--- friends/service/dispatcher.py	2012-11-08 15:08:49 +0000
+++ friends/service/dispatcher.py	2012-11-15 17:40:29 +0000
@@ -61,6 +61,12 @@
         signaler.add_signal('ConnectionOffline', self._on_connection_offline)
         self._on_connection_online()
         self.Refresh()
+        # This needs to be moved somewhere else if we ever create that
+        # event-based architecture and get away from a single long 
+        # running process.
+        for account in self.account_manager.get_all():
+            account.protocol('contacts')
+        
 
     def _on_connection_online(self):
         if self._timer_id is None: