I've looked at the code (briefly) and successfully run all the tests, but I can't actually test that this works, because I don't have access to vsphere. I'm sure you guys are doing integration testing, could you tell us what kind of testing you are doing? Can you give us any visibility into your test environment?
I'm approving this because it looks good and doesn't appear to break anything else, but I would really like to see this in action before release.
I've looked at the code (briefly) and successfully run all the tests, but I can't actually test that this works, because I don't have access to vsphere. I'm sure you guys are doing integration testing, could you tell us what kind of testing you are doing? Can you give us any visibility into your test environment?
I'm approving this because it looks good and doesn't appear to break anything else, but I would really like to see this in action before release.