Code review comment for lp:~cimi/unity8/uitkPageHeader

Revision history for this message
Albert Astals Cid (aacid) wrote :

> > Why the
> > - units.dp(1)
> > in the "Fixed GenericScopeView test" commit?
> there is a test in genericscopeview that checks the position of the listview
> when the header is scrolled up, and there was one pixel difference between
> PageHeadStyle code (using contentHeight for height of the container) and the
> current one using implicitHeight - figured out it need to be smaller of 1px

I'd be more confortable with

- height: header.implicitHeight - units.dp(1)
+ height: header.__styleInstance.contentHeight

What do you think?

« Back to merge proposal