Unity 8

Code review comment for lp:~cimi/unity8/fix-open-new-scope-from-tmp

  1. fix-open-new-scope-from-tmp
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

I don't understand the MR, you're adding to fake_scopes three methods that you don't use and you're removing the code in closeScopes that checks that the scope you closed is indeed a scope that was opened.

Also what's the point of having the scopeThatOpenedScope variable now that you can simply use scopes.closeScope?

review: Needs Information

« Back to merge proposal