Merge lp:~cimi/unity8/fix-1236286 into lp:unity8

Proposed by Andrea Cimitan
Status: Merged
Approved by: Michał Sawicz
Approved revision: 481
Merged at revision: 495
Proposed branch: lp:~cimi/unity8/fix-1236286
Merge into: lp:unity8
Diff against target: 82 lines (+15/-10)
2 files modified
Launcher/Launcher.qml (+1/-1)
tests/qmltests/tst_Shell.qml (+14/-9)
To merge this branch: bzr merge lp:~cimi/unity8/fix-1236286
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+192399@code.launchpad.net

Commit message

Threshold to activate the left edge swipe to reveal dash is now 26 GU

Description of the change

Threshold to activate the left edge swipe to reveal dash is now 26 GU

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:479
http://jenkins.qa.ubuntu.com/job/unity8-ci/1485/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/38
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/38/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/9
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/38
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/38/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/38
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/38/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2667
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2718/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/373
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/374

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1485/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

please adjust the left-edge qml test to check for the distance. For example by once releasing at 25 gus and checking if it's NOT going to the dash, and once with 27 gus and check if it does.

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:480
http://jenkins.qa.ubuntu.com/job/unity8-ci/1491/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/77/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/76
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/15
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/15/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/15
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/68/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/77
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/77/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/76
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/76/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2754
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/449
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/438

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1491/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

thanks :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Unapproved changes made after approval.
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/638/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/388
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/376
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/111
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/24
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/24/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/363
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/388
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/388/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/376
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/376/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2959
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3043
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/998
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/996

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Grr ;)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:481
http://jenkins.qa.ubuntu.com/job/unity8-ci/1561/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/392
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/380
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/85
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/85
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/85/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/85
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/367
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/392
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/392/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/380
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/380/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2961
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3046
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1003
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1002

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1561/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity8-autolanding/639/
Executed test runs:
    SUCCESS: http://10.97.0.26:8080/job/generic-cleanup-mbs/3087
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/393
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/381
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/115
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-autolanding/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/25
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-autolanding/25/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-autolanding/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/368
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/393
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/393/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/381
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/381/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3049
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1007

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Broken maguros, had to restart.

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Launcher/Launcher.qml'
--- Launcher/Launcher.qml 2013-09-12 19:08:06 +0000
+++ Launcher/Launcher.qml 2013-10-25 13:53:41 +0000
@@ -28,7 +28,7 @@
2828
29 property int panelWidth: units.gu(8)29 property int panelWidth: units.gu(8)
30 property int dragAreaWidth: units.gu(1)30 property int dragAreaWidth: units.gu(1)
31 property int minimizeDistance: panelWidth * 2.531 property int minimizeDistance: units.gu(26)
32 property real progress: dragArea.dragging && dragArea.touchX > panelWidth ?32 property real progress: dragArea.dragging && dragArea.touchX > panelWidth ?
33 (width * (dragArea.touchX-panelWidth) / (width - panelWidth)) : 033 (width * (dragArea.touchX-panelWidth) / (width - panelWidth)) : 0
3434
3535
=== modified file 'tests/qmltests/tst_Shell.qml'
--- tests/qmltests/tst_Shell.qml 2013-10-09 20:01:12 +0000
+++ tests/qmltests/tst_Shell.qml 2013-10-25 13:53:41 +0000
@@ -111,14 +111,14 @@
111 waitUntilApplicationWindowIsFullyVisible();111 waitUntilApplicationWindowIsFullyVisible();
112112
113 // Minimize the application we just launched113 // Minimize the application we just launched
114 swipeFromLeftEdge();114 swipeFromLeftEdge(units.gu(27));
115115
116 waitForUIToSettle();116 waitForUIToSettle();
117117
118 checkRightEdgeDragWithMinimizedApp();118 checkRightEdgeDragWithMinimizedApp();
119119
120 // Minimize that application once again120 // Minimize that application once again
121 swipeFromLeftEdge();121 swipeFromLeftEdge(units.gu(27));
122122
123 // Right edge behavior should now be the same as before that app,123 // Right edge behavior should now be the same as before that app,
124 // was launched. Manually cleanup beforehand to get to initial124 // was launched. Manually cleanup beforehand to get to initial
@@ -130,8 +130,10 @@
130130
131 function test_leftEdgeDrag_data() {131 function test_leftEdgeDrag_data() {
132 return [132 return [
133 {tag: "without launcher", revealLauncher: false},133 {tag: "without launcher", revealLauncher: false, swipeLength: units.gu(27), appHides: true},
134 {tag: "with launcher", revealLauncher: true},134 {tag: "with launcher", revealLauncher: true, swipeLength: units.gu(27), appHides: true},
135 {tag: "small swipe", revealLauncher: false, swipeLength: units.gu(25), appHides: false},
136 {tag: "long swipe", revealLauncher: false, swipeLength: units.gu(27), appHides: true}
135 ];137 ];
136 }138 }
137139
@@ -144,8 +146,11 @@
144 dragLauncherIntoView();146 dragLauncherIntoView();
145 }147 }
146148
147 swipeFromLeftEdge();149 swipeFromLeftEdge(data.swipeLength);
148 waitUntilApplicationWindowIsFullyHidden();150 if (data.appHides)
151 waitUntilApplicationWindowIsFullyHidden();
152 else
153 waitUntilApplicationWindowIsFullyVisible();
149 }154 }
150155
151 function test_suspend() {156 function test_suspend() {
@@ -293,7 +298,7 @@
293 waitUntilApplicationWindowIsFullyVisible();298 waitUntilApplicationWindowIsFullyVisible();
294299
295 // Minimize the application we just launched300 // Minimize the application we just launched
296 swipeFromLeftEdge();301 swipeFromLeftEdge(units.gu(27));
297302
298 // Wait for the whole UI to settle down303 // Wait for the whole UI to settle down
299 waitUntilApplicationWindowIsFullyHidden();304 waitUntilApplicationWindowIsFullyHidden();
@@ -376,10 +381,10 @@
376 }381 }
377 }382 }
378383
379 function swipeFromLeftEdge() {384 function swipeFromLeftEdge(swipeLength) {
380 var touchStartX = 2;385 var touchStartX = 2;
381 var touchStartY = shell.height / 2;386 var touchStartY = shell.height / 2;
382 touchFlick(shell, touchStartX, touchStartY, shell.width * 0.75, touchStartY);387 touchFlick(shell, touchStartX, touchStartY, swipeLength, touchStartY);
383 }388 }
384389
385 function swipeLeftFromCenter() {390 function swipeLeftFromCenter() {

Subscribers

People subscribed via source and target branches