Merge lp:~cimi/unity8/dash-filtergrid-renderers into lp:unity8
- dash-filtergrid-renderers
- Merge into trunk
Proposed by
Andrea Cimitan
Status: | Superseded |
---|---|
Proposed branch: | lp:~cimi/unity8/dash-filtergrid-renderers |
Merge into: | lp:unity8 |
Prerequisite: | lp:~mhr3/unity8/expose-renderer-hint |
Diff against target: |
450 lines (+301/-66) 9 files modified
Components/Tile.qml (+6/-63) Components/TileStyle.qml (+87/-0) Dash/Apps/DashPluginFilterGrid.qml (+50/-0) Dash/Generic/FlatTileStyle.qml (+90/-0) Dash/Generic/GenericFilterGrid.qml (+0/-2) Dash/Generic/WeatherFilterGrid.qml (+47/-0) Dash/GenericScopeView.qml (+7/-0) plugins/Unity/categoryresults.cpp (+12/-0) plugins/Unity/categoryresults.h (+2/-1) |
To merge this branch: | bzr merge lp:~cimi/unity8/dash-filtergrid-renderers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Unity Team | Pending | ||
Review via email:
|
This proposal has been superseded by a proposal from 2013-10-03.
Commit message
Make Tile themeable, add renderers for Dash Plugins and weather
Description of the change
Make Tile themeable, add renderers for Dash Plugins and weather
To post a comment you must log in.
- 377. By Andrea Cimitan
-
Add fixme
Revision history for this message
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === modified file 'Components/Tile.qml' | |||
2 | --- Components/Tile.qml 2013-08-05 15:02:05 +0000 | |||
3 | +++ Components/Tile.qml 2013-10-03 16:28:24 +0000 | |||
4 | @@ -18,70 +18,13 @@ | |||
5 | 18 | import Ubuntu.Components 0.1 | 18 | import Ubuntu.Components 0.1 |
6 | 19 | 19 | ||
7 | 20 | AbstractButton { | 20 | AbstractButton { |
14 | 21 | id: root | 21 | property url source |
15 | 22 | property alias source: image.source | 22 | property int fillMode |
16 | 23 | property alias fillMode: image.fillMode | 23 | property int horizontalAlignment |
17 | 24 | property alias horizontalAlignment: image.horizontalAlignment | 24 | property int verticalAlignment |
18 | 25 | property alias verticalAlignment: image.verticalAlignment | 25 | property string text |
13 | 26 | property alias text: label.text | ||
19 | 27 | property int imageWidth | 26 | property int imageWidth |
20 | 28 | property int imageHeight | 27 | property int imageHeight |
21 | 29 | 28 | ||
79 | 30 | UbuntuShape { | 29 | style: TileStyle {} |
23 | 31 | id: icon | ||
24 | 32 | anchors { | ||
25 | 33 | top: parent.top | ||
26 | 34 | horizontalCenter: parent.horizontalCenter | ||
27 | 35 | } | ||
28 | 36 | radius: "medium" | ||
29 | 37 | width: imageWidth | ||
30 | 38 | height: imageHeight | ||
31 | 39 | image: Image { | ||
32 | 40 | id: image | ||
33 | 41 | objectName: "image" | ||
34 | 42 | sourceSize { width: icon.width; height: icon.height } | ||
35 | 43 | asynchronous: true | ||
36 | 44 | cache: false | ||
37 | 45 | } | ||
38 | 46 | } | ||
39 | 47 | |||
40 | 48 | UbuntuShape { | ||
41 | 49 | id: borderPressed | ||
42 | 50 | objectName: "borderPressed" | ||
43 | 51 | |||
44 | 52 | anchors.fill: icon | ||
45 | 53 | radius: "medium" | ||
46 | 54 | borderSource: "radius_pressed.sci" | ||
47 | 55 | opacity: root.pressed ? 1.0 : 0.0 | ||
48 | 56 | Behavior on opacity { NumberAnimation { duration: 200; easing.type: Easing.OutQuint } } | ||
49 | 57 | } | ||
50 | 58 | |||
51 | 59 | Item { | ||
52 | 60 | anchors { | ||
53 | 61 | left: parent.left | ||
54 | 62 | right: parent.right | ||
55 | 63 | top: icon.bottom | ||
56 | 64 | } | ||
57 | 65 | height: units.gu(2) | ||
58 | 66 | |||
59 | 67 | Label { | ||
60 | 68 | id: label | ||
61 | 69 | objectName: "label" | ||
62 | 70 | anchors { | ||
63 | 71 | baseline: parent.bottom | ||
64 | 72 | left: parent.left | ||
65 | 73 | right: parent.right | ||
66 | 74 | leftMargin: units.gu(1) | ||
67 | 75 | rightMargin: units.gu(1) | ||
68 | 76 | } | ||
69 | 77 | |||
70 | 78 | color: Theme.palette.selected.backgroundText | ||
71 | 79 | opacity: 0.9 | ||
72 | 80 | style: Text.Raised | ||
73 | 81 | styleColor: "black" | ||
74 | 82 | fontSize: "small" | ||
75 | 83 | elide: Text.ElideMiddle | ||
76 | 84 | horizontalAlignment: Text.AlignHCenter | ||
77 | 85 | } | ||
78 | 86 | } | ||
80 | 87 | } | 30 | } |
81 | 88 | 31 | ||
82 | === added file 'Components/TileStyle.qml' | |||
83 | --- Components/TileStyle.qml 1970-01-01 00:00:00 +0000 | |||
84 | +++ Components/TileStyle.qml 2013-10-03 16:28:24 +0000 | |||
85 | @@ -0,0 +1,87 @@ | |||
86 | 1 | /* | ||
87 | 2 | * Copyright (C) 2013 Canonical, Ltd. | ||
88 | 3 | * | ||
89 | 4 | * This program is free software; you can redistribute it and/or modify | ||
90 | 5 | * it under the terms of the GNU General Public License as published by | ||
91 | 6 | * the Free Software Foundation; version 3. | ||
92 | 7 | * | ||
93 | 8 | * This program is distributed in the hope that it will be useful, | ||
94 | 9 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
95 | 10 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
96 | 11 | * GNU General Public License for more details. | ||
97 | 12 | * | ||
98 | 13 | * You should have received a copy of the GNU General Public License | ||
99 | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
100 | 15 | */ | ||
101 | 16 | |||
102 | 17 | import QtQuick 2.0 | ||
103 | 18 | import Ubuntu.Components 0.1 | ||
104 | 19 | |||
105 | 20 | Item { | ||
106 | 21 | id: tile | ||
107 | 22 | |||
108 | 23 | anchors.fill: parent | ||
109 | 24 | |||
110 | 25 | UbuntuShape { | ||
111 | 26 | id: icon | ||
112 | 27 | anchors { | ||
113 | 28 | top: parent.top | ||
114 | 29 | horizontalCenter: parent.horizontalCenter | ||
115 | 30 | } | ||
116 | 31 | radius: "medium" | ||
117 | 32 | width: styledItem.imageWidth | ||
118 | 33 | height: styledItem.imageHeight | ||
119 | 34 | image: Image { | ||
120 | 35 | id: image | ||
121 | 36 | objectName: "image" | ||
122 | 37 | sourceSize { width: icon.width; height: icon.height } | ||
123 | 38 | asynchronous: true | ||
124 | 39 | cache: false | ||
125 | 40 | source: styledItem.source | ||
126 | 41 | fillMode: styledItem.fillMode | ||
127 | 42 | horizontalAlignment: styledItem.horizontalAlignment | ||
128 | 43 | verticalAlignment: styledItem.verticalAlignment | ||
129 | 44 | } | ||
130 | 45 | } | ||
131 | 46 | |||
132 | 47 | UbuntuShape { | ||
133 | 48 | id: borderPressed | ||
134 | 49 | objectName: "borderPressed" | ||
135 | 50 | |||
136 | 51 | anchors.fill: icon | ||
137 | 52 | radius: "medium" | ||
138 | 53 | borderSource: "radius_pressed.sci" | ||
139 | 54 | opacity: styledItem.pressed ? 1.0 : 0.0 | ||
140 | 55 | Behavior on opacity { NumberAnimation { duration: 200; easing.type: Easing.OutQuint } } | ||
141 | 56 | } | ||
142 | 57 | |||
143 | 58 | Item { | ||
144 | 59 | anchors { | ||
145 | 60 | left: parent.left | ||
146 | 61 | right: parent.right | ||
147 | 62 | top: icon.bottom | ||
148 | 63 | } | ||
149 | 64 | height: units.gu(2) | ||
150 | 65 | |||
151 | 66 | Label { | ||
152 | 67 | id: label | ||
153 | 68 | objectName: "label" | ||
154 | 69 | anchors { | ||
155 | 70 | baseline: parent.bottom | ||
156 | 71 | left: parent.left | ||
157 | 72 | right: parent.right | ||
158 | 73 | leftMargin: units.gu(1) | ||
159 | 74 | rightMargin: units.gu(1) | ||
160 | 75 | } | ||
161 | 76 | |||
162 | 77 | color: Theme.palette.selected.backgroundText | ||
163 | 78 | opacity: 0.9 | ||
164 | 79 | style: Text.Raised | ||
165 | 80 | styleColor: "black" | ||
166 | 81 | fontSize: "small" | ||
167 | 82 | elide: Text.ElideMiddle | ||
168 | 83 | horizontalAlignment: Text.AlignHCenter | ||
169 | 84 | text: styledItem.text | ||
170 | 85 | } | ||
171 | 86 | } | ||
172 | 87 | } | ||
173 | 0 | 88 | ||
174 | === added file 'Dash/Apps/DashPluginFilterGrid.qml' | |||
175 | --- Dash/Apps/DashPluginFilterGrid.qml 1970-01-01 00:00:00 +0000 | |||
176 | +++ Dash/Apps/DashPluginFilterGrid.qml 2013-10-03 16:28:24 +0000 | |||
177 | @@ -0,0 +1,50 @@ | |||
178 | 1 | /* | ||
179 | 2 | * Copyright (C) 2013 Canonical, Ltd. | ||
180 | 3 | * | ||
181 | 4 | * This program is free software; you can redistribute it and/or modify | ||
182 | 5 | * it under the terms of the GNU General Public License as published by | ||
183 | 6 | * the Free Software Foundation; version 3. | ||
184 | 7 | * | ||
185 | 8 | * This program is distributed in the hope that it will be useful, | ||
186 | 9 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
187 | 10 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
188 | 11 | * GNU General Public License for more details. | ||
189 | 12 | * | ||
190 | 13 | * You should have received a copy of the GNU General Public License | ||
191 | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
192 | 15 | */ | ||
193 | 16 | |||
194 | 17 | import QtQuick 2.0 | ||
195 | 18 | import Ubuntu.Components 0.1 | ||
196 | 19 | import "../../Components" | ||
197 | 20 | import "../Generic" | ||
198 | 21 | |||
199 | 22 | GenericFilterGrid { | ||
200 | 23 | id: filtergrid | ||
201 | 24 | |||
202 | 25 | delegate: Tile { | ||
203 | 26 | id: tile | ||
204 | 27 | objectName: "delegate" + index | ||
205 | 28 | width: filtergrid.cellWidth | ||
206 | 29 | height: filtergrid.cellHeight | ||
207 | 30 | text: model.title | ||
208 | 31 | imageWidth: filtergrid.iconWidth | ||
209 | 32 | imageHeight: filtergrid.iconHeight | ||
210 | 33 | source: model.icon | ||
211 | 34 | fillMode: Image.PreserveAspectCrop | ||
212 | 35 | |||
213 | 36 | style: FlatTileStyle { | ||
214 | 37 | disabled: model.scopeDisabled | ||
215 | 38 | } | ||
216 | 39 | |||
217 | 40 | onClicked: { | ||
218 | 41 | var data = { model: model } | ||
219 | 42 | filtergrid.clicked(index, data, tile.y) | ||
220 | 43 | } | ||
221 | 44 | |||
222 | 45 | onPressAndHold: { | ||
223 | 46 | var data = { model: model } | ||
224 | 47 | filtergrid.pressAndHold(index, data, tile.y) | ||
225 | 48 | } | ||
226 | 49 | } | ||
227 | 50 | } | ||
228 | 0 | 51 | ||
229 | === added file 'Dash/Generic/FlatTileStyle.qml' | |||
230 | --- Dash/Generic/FlatTileStyle.qml 1970-01-01 00:00:00 +0000 | |||
231 | +++ Dash/Generic/FlatTileStyle.qml 2013-10-03 16:28:24 +0000 | |||
232 | @@ -0,0 +1,90 @@ | |||
233 | 1 | /* | ||
234 | 2 | * Copyright (C) 2013 Canonical, Ltd. | ||
235 | 3 | * | ||
236 | 4 | * This program is free software; you can redistribute it and/or modify | ||
237 | 5 | * it under the terms of the GNU General Public License as published by | ||
238 | 6 | * the Free Software Foundation; version 3. | ||
239 | 7 | * | ||
240 | 8 | * This program is distributed in the hope that it will be useful, | ||
241 | 9 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
242 | 10 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
243 | 11 | * GNU General Public License for more details. | ||
244 | 12 | * | ||
245 | 13 | * You should have received a copy of the GNU General Public License | ||
246 | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
247 | 15 | */ | ||
248 | 16 | |||
249 | 17 | import QtQuick 2.0 | ||
250 | 18 | import Ubuntu.Components 0.1 | ||
251 | 19 | |||
252 | 20 | Item { | ||
253 | 21 | id: tile | ||
254 | 22 | |||
255 | 23 | property bool disabled: false | ||
256 | 24 | |||
257 | 25 | anchors.fill: parent | ||
258 | 26 | |||
259 | 27 | Item { | ||
260 | 28 | id: icon | ||
261 | 29 | anchors { | ||
262 | 30 | top: parent.top | ||
263 | 31 | horizontalCenter: parent.horizontalCenter | ||
264 | 32 | } | ||
265 | 33 | width: styledItem.imageWidth | ||
266 | 34 | height: styledItem.imageHeight | ||
267 | 35 | |||
268 | 36 | Image { | ||
269 | 37 | id: image | ||
270 | 38 | objectName: "image" | ||
271 | 39 | sourceSize { width: icon.width; height: icon.height } | ||
272 | 40 | asynchronous: true | ||
273 | 41 | cache: false | ||
274 | 42 | source: styledItem.source | ||
275 | 43 | fillMode: styledItem.fillMode | ||
276 | 44 | opacity: tile.disabled ? 0.5 : 1.0 | ||
277 | 45 | horizontalAlignment: styledItem.horizontalAlignment | ||
278 | 46 | verticalAlignment: styledItem.verticalAlignment | ||
279 | 47 | } | ||
280 | 48 | } | ||
281 | 49 | |||
282 | 50 | UbuntuShape { | ||
283 | 51 | id: borderPressed | ||
284 | 52 | objectName: "borderPressed" | ||
285 | 53 | |||
286 | 54 | anchors.fill: icon | ||
287 | 55 | radius: "medium" | ||
288 | 56 | borderSource: "radius_pressed.sci" | ||
289 | 57 | opacity: styledItem.pressed ? 1.0 : 0.0 | ||
290 | 58 | Behavior on opacity { NumberAnimation { duration: 200; easing.type: Easing.OutQuint } } | ||
291 | 59 | } | ||
292 | 60 | |||
293 | 61 | Item { | ||
294 | 62 | anchors { | ||
295 | 63 | left: parent.left | ||
296 | 64 | right: parent.right | ||
297 | 65 | top: icon.bottom | ||
298 | 66 | } | ||
299 | 67 | height: units.gu(2) | ||
300 | 68 | |||
301 | 69 | Label { | ||
302 | 70 | id: label | ||
303 | 71 | objectName: "label" | ||
304 | 72 | anchors { | ||
305 | 73 | baseline: parent.bottom | ||
306 | 74 | left: parent.left | ||
307 | 75 | right: parent.right | ||
308 | 76 | leftMargin: units.gu(1) | ||
309 | 77 | rightMargin: units.gu(1) | ||
310 | 78 | } | ||
311 | 79 | |||
312 | 80 | color: Theme.palette.selected.backgroundText | ||
313 | 81 | opacity: 0.9 | ||
314 | 82 | style: Text.Raised | ||
315 | 83 | styleColor: "black" | ||
316 | 84 | fontSize: "small" | ||
317 | 85 | elide: Text.ElideMiddle | ||
318 | 86 | horizontalAlignment: Text.AlignHCenter | ||
319 | 87 | text: styledItem.text | ||
320 | 88 | } | ||
321 | 89 | } | ||
322 | 90 | } | ||
323 | 0 | 91 | ||
324 | === modified file 'Dash/Generic/GenericFilterGrid.qml' | |||
325 | --- Dash/Generic/GenericFilterGrid.qml 2013-09-05 10:02:00 +0000 | |||
326 | +++ Dash/Generic/GenericFilterGrid.qml 2013-10-03 16:28:24 +0000 | |||
327 | @@ -39,9 +39,7 @@ | |||
328 | 39 | text: model.title | 39 | text: model.title |
329 | 40 | imageWidth: filtergrid.iconWidth | 40 | imageWidth: filtergrid.iconWidth |
330 | 41 | imageHeight: filtergrid.iconHeight | 41 | imageHeight: filtergrid.iconHeight |
331 | 42 | |||
332 | 43 | source: model.icon | 42 | source: model.icon |
333 | 44 | |||
334 | 45 | fillMode: Image.PreserveAspectCrop | 43 | fillMode: Image.PreserveAspectCrop |
335 | 46 | 44 | ||
336 | 47 | onClicked: { | 45 | onClicked: { |
337 | 48 | 46 | ||
338 | === added file 'Dash/Generic/WeatherFilterGrid.qml' | |||
339 | --- Dash/Generic/WeatherFilterGrid.qml 1970-01-01 00:00:00 +0000 | |||
340 | +++ Dash/Generic/WeatherFilterGrid.qml 2013-10-03 16:28:24 +0000 | |||
341 | @@ -0,0 +1,47 @@ | |||
342 | 1 | /* | ||
343 | 2 | * Copyright (C) 2013 Canonical, Ltd. | ||
344 | 3 | * | ||
345 | 4 | * This program is free software; you can redistribute it and/or modify | ||
346 | 5 | * it under the terms of the GNU General Public License as published by | ||
347 | 6 | * the Free Software Foundation; version 3. | ||
348 | 7 | * | ||
349 | 8 | * This program is distributed in the hope that it will be useful, | ||
350 | 9 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
351 | 10 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
352 | 11 | * GNU General Public License for more details. | ||
353 | 12 | * | ||
354 | 13 | * You should have received a copy of the GNU General Public License | ||
355 | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
356 | 15 | */ | ||
357 | 16 | |||
358 | 17 | import QtQuick 2.0 | ||
359 | 18 | import Ubuntu.Components 0.1 | ||
360 | 19 | import "../../Components" | ||
361 | 20 | |||
362 | 21 | GenericFilterGrid { | ||
363 | 22 | id: filtergrid | ||
364 | 23 | |||
365 | 24 | delegate: Tile { | ||
366 | 25 | id: tile | ||
367 | 26 | objectName: "delegate" + index | ||
368 | 27 | width: filtergrid.cellWidth | ||
369 | 28 | height: filtergrid.cellHeight | ||
370 | 29 | text: model.title | ||
371 | 30 | imageWidth: filtergrid.iconWidth | ||
372 | 31 | imageHeight: filtergrid.iconHeight | ||
373 | 32 | source: model.icon | ||
374 | 33 | fillMode: Image.PreserveAspectCrop | ||
375 | 34 | |||
376 | 35 | style: FlatTileStyle {} | ||
377 | 36 | |||
378 | 37 | onClicked: { | ||
379 | 38 | var data = { model: model } | ||
380 | 39 | filtergrid.clicked(index, data, tile.y) | ||
381 | 40 | } | ||
382 | 41 | |||
383 | 42 | onPressAndHold: { | ||
384 | 43 | var data = { model: model } | ||
385 | 44 | filtergrid.pressAndHold(index, data, tile.y) | ||
386 | 45 | } | ||
387 | 46 | } | ||
388 | 47 | } | ||
389 | 0 | 48 | ||
390 | === modified file 'Dash/GenericScopeView.qml' | |||
391 | --- Dash/GenericScopeView.qml 2013-10-03 16:28:24 +0000 | |||
392 | +++ Dash/GenericScopeView.qml 2013-10-03 16:28:24 +0000 | |||
393 | @@ -209,6 +209,13 @@ | |||
394 | 209 | switch (contentType) { | 209 | switch (contentType) { |
395 | 210 | case "video": return "Generic/GenericFilterGridPotrait.qml"; | 210 | case "video": return "Generic/GenericFilterGridPotrait.qml"; |
396 | 211 | case "music": return "Music/MusicFilterGrid.qml"; | 211 | case "music": return "Music/MusicFilterGrid.qml"; |
397 | 212 | case "apps": { | ||
398 | 213 | if (rendererHint == "toggled") | ||
399 | 214 | return "Apps/DashPluginFilterGrid.qml"; | ||
400 | 215 | else | ||
401 | 216 | return "Generic/GenericFilterGrid.qml"; | ||
402 | 217 | } | ||
403 | 218 | case "weather": return "Generic/WeatherFilterGrid.qml"; | ||
404 | 212 | default: return "Generic/GenericFilterGrid.qml"; | 219 | default: return "Generic/GenericFilterGrid.qml"; |
405 | 213 | } | 220 | } |
406 | 214 | } | 221 | } |
407 | 215 | 222 | ||
408 | === modified file 'plugins/Unity/categoryresults.cpp' | |||
409 | --- plugins/Unity/categoryresults.cpp 2013-10-01 15:46:09 +0000 | |||
410 | +++ plugins/Unity/categoryresults.cpp 2013-10-03 16:28:24 +0000 | |||
411 | @@ -46,6 +46,7 @@ | |||
412 | 46 | m_roles[CategoryResults::RoleComment] = "comment"; | 46 | m_roles[CategoryResults::RoleComment] = "comment"; |
413 | 47 | m_roles[CategoryResults::RoleDndUri] = "dndUri"; | 47 | m_roles[CategoryResults::RoleDndUri] = "dndUri"; |
414 | 48 | m_roles[CategoryResults::RoleMetadata] = "metadata"; | 48 | m_roles[CategoryResults::RoleMetadata] = "metadata"; |
415 | 49 | m_roles[CategoryResults::RoleMetadataScopeDisabled] = "scopeDisabled"; | ||
416 | 49 | } | 50 | } |
417 | 50 | 51 | ||
418 | 51 | int CategoryResults::categoryIndex() const | 52 | int CategoryResults::categoryIndex() const |
419 | @@ -100,6 +101,17 @@ | |||
420 | 100 | return DeeListModel::data(index, ResultsColumn::DND_URI); | 101 | return DeeListModel::data(index, ResultsColumn::DND_URI); |
421 | 101 | case RoleMetadata: | 102 | case RoleMetadata: |
422 | 102 | return DeeListModel::data(index, ResultsColumn::METADATA); | 103 | return DeeListModel::data(index, ResultsColumn::METADATA); |
423 | 104 | // FIXME nasty hack while we don't support annotated icons | ||
424 | 105 | case RoleMetadataScopeDisabled: { | ||
425 | 106 | QVariantHash hash(DeeListModel::data(index, ResultsColumn::METADATA).toHash()); | ||
426 | 107 | if (hash.contains("content")) { | ||
427 | 108 | QVariantHash innerHash(hash["content"].toHash()); | ||
428 | 109 | if (innerHash.contains("scope_disabled")) { | ||
429 | 110 | return innerHash["scope_disabled"]; | ||
430 | 111 | } | ||
431 | 112 | } | ||
432 | 113 | return QVariant(); | ||
433 | 114 | } | ||
434 | 103 | default: | 115 | default: |
435 | 104 | return QVariant(); | 116 | return QVariant(); |
436 | 105 | } | 117 | } |
437 | 106 | 118 | ||
438 | === modified file 'plugins/Unity/categoryresults.h' | |||
439 | --- plugins/Unity/categoryresults.h 2013-09-05 11:48:57 +0000 | |||
440 | +++ plugins/Unity/categoryresults.h 2013-10-03 16:28:24 +0000 | |||
441 | @@ -43,7 +43,8 @@ | |||
442 | 43 | RoleTitle, | 43 | RoleTitle, |
443 | 44 | RoleComment, | 44 | RoleComment, |
444 | 45 | RoleDndUri, | 45 | RoleDndUri, |
446 | 46 | RoleMetadata | 46 | RoleMetadata, |
447 | 47 | RoleMetadataScopeDisabled | ||
448 | 47 | }; | 48 | }; |
449 | 48 | 49 | ||
450 | 49 | QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const; | 50 | QVariant data(const QModelIndex& index, int role = Qt::DisplayRole) const; |
FAILED: Continuous integration, rev:377 jenkins. qa.ubuntu. com/job/ unity8- ci/1248/ jenkins. qa.ubuntu. com/job/ generic- mediumtests- saucy/4475 jenkins. qa.ubuntu. com/job/ generic- mediumtests- touch/2246/ console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- saucy/2060 jenkins. qa.ubuntu. com/job/ unity8- saucy-amd64- ci/271 jenkins. qa.ubuntu. com/job/ unity8- saucy-armhf- ci/1248/ console jenkins. qa.ubuntu. com/job/ unity8- saucy-i386- ci/1247/ console jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-saucy/ 756 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-amd64/ 350 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-amd64/ 350/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 2248 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 2248/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- maguro/ 1917/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- mako/1934
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
FAILURE: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity8- ci/1248/ rebuild
http://