Merge lp:~cimi/unity8/card_touchdown into lp:unity8
| Status: | Rejected |
|---|---|
| Rejected by: | Michał Sawicz |
| Proposed branch: | lp:~cimi/unity8/card_touchdown |
| Merge into: | lp:unity8 |
| Diff against target: |
605 lines (+232/-145) 9 files modified
plugins/Dash/CardCreator.js (+21/-1) tests/plugins/Dash/cardcreator/1.res (+40/-32) tests/plugins/Dash/cardcreator/2.res (+60/-51) tests/plugins/Dash/cardcreator/3.res (+36/-28) tests/plugins/Dash/cardcreator/4.res (+39/-31) tests/plugins/Dash/cardcreator/5.res (+8/-0) tests/plugins/Dash/cardcreator/6.res (+8/-0) tests/plugins/Dash/cardcreatortest.cpp (+8/-2) tests/qmltests/Dash/tst_Card.qml (+12/-0) |
| To merge this branch: | bzr merge lp:~cimi/unity8/card_touchdown |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michał Sawicz | Disapprove | ||
| Albert Astals Cid (community) | Abstain | ||
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
|
Review via email:
|
|||
Commit message
Add touchdown effect
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
Nope
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
Nope, but is consistent with the rest of the OS
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| Albert Astals Cid (aacid) wrote | # |
| Michał Sawicz (saviq) wrote | # |
| Albert Astals Cid (aacid) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| Michał Sawicz (saviq) wrote | # |
| Michał Sawicz (saviq) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
Unmerged revisions
- 925. By Andrea Cimitan
-
Removed newline
- 924. By Andrea Cimitan
-
[ thomas-voss ]
* Explicitly select gcc version.
[ Michael Terry ]
* Allow running the dialer-app in emergency mode when the screen is
locked.
[ Michał Sawicz ]
* Add missing nameOwner property to mock UnityMenuModel.
[ Albert Astals ]
* Fix name, There's nothing called pageHeader in this file
[ Nick Dedekind ]
* Added environment variable to upstart conf for mir trusted socket
* Removed indicator menu dismissal on menu activation (LP: #1337771)
[ Michał Sawicz ]
* Only generate .qmltypes files manually, no need to do it build-time.
It didn't work when cross-compiling either, and required builders to
have otherwise unnecessary environment.
* Fix CardCreator test. It got broken with a merge that got landed
along side of it.
[ Ying-Chun Liu ]
* Add reboot/shutdown (LP: #1234062)
[ Albert Astals ]
* Make the departments test more stable
[ Mirco Müller ]
* Fixes gap at top of sim-unlock/fullscreen notification (point 1.),
fixes blocking overlay if underlying UnityMenuModel vanishes from
DBus (point 2.). The third bullet-point of the bug-report, lockup of
shell-UI, could not be reproduced. (LP: #1308011)
[ Michael Terry ]
* Expose a new greeter DBus property, IsActive, which tells apps and
indicators when the integrated-greeter screen is active. Useful for
switching UI modes when the screen is locked.
* Allow the session to bring up the greeter/lockscreen over DBus. The
emergency dialer will need this support in order to cancel bringing
it up.
[ Michael Zanetti ]
* Fixes gap at top of sim-unlock/fullscreen notification (point 1.),
fixes blocking overlay if underlying UnityMenuModel vanishes from
DBus (point 2.). The third bullet-point of the bug-report, lockup of
shell-UI, could not be reproduced. (LP: #1308011)
[ Michał Sawicz ]
* Activate all results in click scope by default. (LP: #1341262)
[ Mirco Müller ]
* Added support for utilization of the ComboButton SDK-element for
snap-decision notifications with many actions.
[ Michal Hruby ]
* Fix FTBFS when using latest unity-api.
[ Michał Sawicz ]
* Refactor carousel item activation.
* Refactor ScopeItem into GenericScopeView.
* Add initial support for scope customizations.
* Make rating stars in PreviewReviewDisplay.qml non-interactive. (LP:
#1337508)
[ Nick Dedekind ]
* Added active call hint A hint is displayed in the indicator panel
when an call is active on the Telephony Serivce
[ Albert Astals ]
* We need to boostrap height also when we have 1 item ^_^ (LP:
#1337408)
* Add initial support for scope customizations.
* CardCreator: Give a correct implicitHeight if we only have art The
hasSubtitle change is really unrelated and not needed here, just
sneaking it in to not create yet another review. (LP: #1330899)
* Fake Scopes Plugin: Register PreviewModelInterface
[ Michael Zanetti ]
* make the launcher's drag'n'drop indicator more prominent (LP:
#1332042)
* make launcher items live having them non-live is not really required
and reveals an issue in combination with UbuntuShape (LP: #1302761)
* Fade out launcher in place instead of moving it to the left on long
left edge swipes. (LP: #1332096)
* update launcher icon glow as requested by design (LP: #1336725)
* update header in dash to use the new header from the SDK (LP:
#1335491)
* fix testPreview with larger GRID_UNIT_PX values
* clip the corner of pinned icons in the launcher as per new design
* update launcher background according to latest design (LP: #1336314)
* Update Launcher's home button design according to new spec. (LP:
#1329331)
[ CI bot ]
* make launcher items live having them non-live is not really required
and reveals an issue in combination with UbuntuShape (LP: #1302761)
[ Nick Dedekind ]
* Added support for TransferMenu
[ Michał Sawicz ]
* Initial code for a payment button widget, to handle purchasing apps
from the click scope.
[ Nick Dedekind ]
* Moved [Message]MenuItemFacotor y from Unity.Indicators plugin to qml
folder.
[ Albert Astals ]
* EasingCurve: Initialize members
* Fix valgrind warning by not emitting reset on model destructor That
won't be supported until Qt 5.4 More info at https://bugreports. qt-
project.org/browse/ QTBUG-39780 Warning was ==16693== Invalid read of
size 8 ==16693== at 0x72B19A0: QQmlContext::isValid( ) const
(qqmlcontext.cpp:231) ==16693== by 0x736C82B:
QQmlDelegateModelPrivate: :emitChanges( ) (qqmldelegatemo del.cpp: 1412)
==16693== by 0x7372AE6: QQmlDelegateModel::_q_ modelReset( )
(qqmldelegatemodel.cpp: 1463) ==16693== by 0x7397224:
QQmlDelegateModel::qt_ static_ metacall( QObject* , QMetaObject::Call,
int, void**) (moc_qqmldelegatemodel_ p.cpp:196) ==16693== by
0x739769E: QQmlDelegateModel::qt_ metacall( QMetaObject: :Call, int,
void**) (moc_qqmldelegatemodel_ p.cpp:292) ==16693== by 0x66379CC:
QMetaObject::activate( QObject* , int, int, void**) (in
/usr/lib/x86_ 64-linux- gnu/libQt5Core. so.5.3. 0) ==16693== by
0x65AEEFD: QAbstractItemModel::endResetMo del() (in /usr/lib/x86_64-
linux-gnu/libQt5Core. so.5.3. 0) ==16693== by 0x23461EFD:
FakeIndicatorsModel: :unload( ) (fakeindicators model.cpp: 53) ==16693==
by 0x23461E13: FakeIndicatorsModel::~ FakeIndicatorsM odel()
(fakeindicatorsmodel. cpp:34) ==16693== by 0x2345C073:
QQmlPrivate::QQmlElement< FakeIndicatorsM odel>:: ~QQmlElement( ) (in
/home/tsdgeos_ work/phablet/ unity8/ investigate_ test_shell_ crash/build
dir/tests/mocks/Unity/ Indicators/ libIndicatorsFa keQml.so) ==16693==
by 0x2345C0A3:
QQmlPrivate::QQmlElement< FakeIndicatorsM odel>:: ~QQmlElement( )
(qqmlprivate.h:106) ==16693== by 0x663636B:
QObjectPrivate::deleteChildr en() (in /usr/lib/ x86_64- linux-
gnu/libQt5Core.so.5. 3.0) ==16693== Address 0x1862d448 is 8 bytes
inside a block of size 16 free'd ==16693== at 0x4C2C2BC: operator
delete(void*) (vg_replace_malloc. c:503) ==16693== by 0x72B21B8:
QQmlContextData::destroy( ) (qqmlcontext. cpp:647) ==16693== by
0x7293458: QQmlPrivate::qdeclarativeel ement_destructo r(QObject* )
(qqmlengine.cpp:612) ==16693== by 0x6C0CADD:
QQmlPrivate::QQmlElement< QQuickItem> ::~QQmlElement( )
(qqmlprivate.h:105) ==16693== by 0x663636B:
QObjectPrivate::deleteChildr en() (in /usr/lib/ x86_64- linux-
gnu/libQt5Core.so.5. 3.0) ==16693== by 0x663F0EB: QObject::~QObject()
(in /usr/lib/x86_64- linux-gnu/ libQt5Core. so.5.3. 0) ==16693== by
0x6BF64B5: QQuickItem::~QQuickItem( ) (qquickitem. cpp:2064) ==16693==
by 0x6C0CAE5: QQmlPrivate::QQmlElement< QQuickItem> ::~QQmlElement( )
(qqmlprivate.h:106) ==16693== by 0x663636B:
QObjectPrivate::deleteChildr en() (in /usr/lib/ x86_64- linux-
gnu/libQt5Core.so.5. 3.0) ==16693== by 0x663F0EB: QObject::~QObject()
(in /usr/lib/x86_64- linux-gnu/ libQt5Core. so.5.3. 0) ==16693== by
0x6BF64B5: QQuickItem::~QQuickItem( ) (qquickitem. cpp:2064) ==16693==
by 0x6C0CAE5: QQmlPrivate::QQmlElement< QQuickItem> ::~QQmlElement( )
(qqmlprivate.h:106) (LP: #1332598)
[ Michael Zanetti ]
* drop launcher item spacing (LP: #1332022)
* change wording in launcher quicklist (LP: #1332035)
[ Alejandro J. Cura ]
* Initial code for a payment button widget, to handle purchasing apps
from the click scope.
[ Rodney Dawes ]
* Initial code for a payment button widget, to handle purchasing apps
from the click scope.
[ Renato Araujo Oliveira Filho ]
* Create IndicatorsLight.qml component used to control indicator led.
A blue led will pulse if the message indicator is blue and screen is
off.
* debian/control:
list qtdeclarative5-ubuntu- ui-toolkit- plugin- gles as an alternative
choice, since provides are not versionned, should restore installability
on amd64 and i386
[ Michał Sawicz ]
* Adapt to suru theme.
[ Michael Terry ]
* Fix path in launcher mock after moving our mock icons, to avoid a
lot of "icon not found" warnings during qmluitests.
* Fix the testMultiGreeter qmluitest. Incoming method variables are
apparently read-only in Qt5.3. (LP: #1332488)
[ CI bot ]
* Resync trunk
[ Michał Sawicz ]
* Adapt scope mock to new api and quiet unused variable warnings.
* Fix dynamic overlay height. (LP: #1334879)
* Don't center items in CardVerticalJournal, kind of beats the
purpose... Also don't bind unnecessarily.
[ Ying-Chun Liu ]
* Fix LP:1330957 Fix some failed test cases. (LP: #1330957)
[ Albert Astals ]
* Don't seem to need this waitForRendering And makes test fail in 5.3
[ Alberto Aguirre ]
* Update Powerd plugin and Shell.qml to accommodate changes in the
display power state notification.
[ Ying-Chun Liu ]
* Add logout support. Reviewed by: Daniel d'Andrada (LP: #1302213) - 923. By Andrea Cimitan
-
[ Michał Sawicz ]
* Make so that fixedArtShapeSize actually fixes artShapeSize.
[ Albert Astals ]
* Add VerticalJournal integration to Dash/scopes/QML (LP: #1326467)
* Make so that fixedArtShapeSize actually fixes artShapeSize.
[ Mirco Müller ]
* Added the frontend-part of sound-hint support for notifications with
updated QML-tests.
* New rebuild forced
[ Albert Astals ]
* Departments support (LP: #1320847)
[ Pawel Stolowski ]
* Extend the hack for click scope categories with the upcoming 'store'
category: single-tap on results from the 'store' category should
activate them, instead of requesting a preview. (LP: #1326292)
[ Albert Astals ]
* Drop the " Preview" suffix from Preview title As requested in
https://bugs.launchpad .net/unity8/ +bug/1316671 (LP: #1316671)
[ Michael Terry ]
* Revert split greeter for now. We will bring it back as an option
for Desktop, but use a big hammer revert right now to get Touch back
in shape.
[ CI bot ]
* Fix build problems. Reviewed by: Michael Terry (LP: #1328850)
[ Michał Sawicz ]
* Make lockscreen buttons translatable.
[ Albert Astals ]
* Correctly mark these functions as overrides
* Remove connections to non existant signal
* Better test name
* Improvements for headerless categories LVPWH: No section name -> no
header LVPWH: New hasSectionHeader context property for delegates
GSV: Add topMargin if no hasSectionHeader (LP: #1326415)
* Make tryVerticalJournal, tryHorizontalJournal and tryOrganicGrid
work again
[ Michael Zanetti ]
* Don't crash when we get an invalid app from ApplicationManager (LP:
#1309162)
[ Andrea Cimitan ]
* Workaround for lp1324159 (LP: #1322233, #1324159)
[ CI bot ]
* Resync trunk
[ Florian Boucault ]
* Application startup: changed splash rectangle to be black instead of
white and added a neat little animation. (LP: #1124265) - 922. By Andrea Cimitan
-
New effect
- 921. By Andrea Cimitan
-
Merged albert branch with fixes for icon size
- 920. By Andrea Cimitan
-
Merged trunk
- 919. By Andrea Cimitan
-
Fixed tests and holder shape
- 918. By Andrea Cimitan
-
Added touchdown effect and tests
FAILED: Continuous integration, rev:919
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://