Unity8 should not request preview for the upcoming 'store' category in Apps
Bug #1326292 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scope-click (Ubuntu) |
Invalid
|
Undecided
|
Paweł Stołowski | ||
| unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Michał Sawicz | ||
Bug Description
A new category will soon be provided by click scope, as per latest design. The category will have the id = 'store'. Items displayed in this category should not display previews (or at least not by default - needs to be clarified with design).
We currently have a "hack" in the shell to treat "local" apps category that way. I think we should come up with a generic mechanism for supporting that kind of behavior, rather than extending the hack for 'store'.
Related branches
lp:~stolowski/unity-scopes-api/define-click-behavior
- PS Jenkins bot (community): Approve (continuous-integration)
- Pete Woods (community): Approve
-
Diff: 549 lines (+196/-23)17 files modifiedCMakeLists.txt (+1/-1)
STRUCTS (+2/-0)
debian/changelog (+2/-1)
debian/libunity-scopes1.symbols (+4/-0)
include/unity/scopes/Category.h (+26/-0)
include/unity/scopes/SearchReply.h (+38/-8)
include/unity/scopes/internal/CategoryImpl.h (+7/-0)
include/unity/scopes/internal/CategoryRegistry.h (+3/-1)
include/unity/scopes/internal/SearchReplyImpl.h (+9/-1)
include/unity/scopes/testing/MockSearchReply.h (+7/-0)
src/scopes/Category.cpp (+15/-0)
src/scopes/internal/CategoryImpl.cpp (+28/-6)
src/scopes/internal/CategoryRegistry.cpp (+4/-2)
src/scopes/internal/SearchReplyImpl.cpp (+17/-1)
src/scopes/testing/InProcessBenchmark.cpp (+12/-1)
test/gtest/scopes/Category/Category_test.cpp (+8/-0)
test/gtest/scopes/internal/CategoryRegistry/CategoryRegistry_test.cpp (+13/-1)
lp:~stolowski/unity8/apps-store-id-hack
- PS Jenkins bot (community): Approve (continuous-integration)
- Michael Zanetti (community): Approve
- Michał Sawicz: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedqml/Dash/GenericScopeView.qml (+1/-1)
| summary: |
- Unity8 should not request preview for the upcoming 'store' category + Unity8 should not request preview for the upcoming 'store' category in + Apps |
Revision history for this message
| Michał Sawicz (saviq) wrote | #1 |
Revision history for this message
| Mike Nagle (mikenagle) wrote | #2 |
| Changed in unity-api: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-api: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-shell: | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-api: | |
| importance: | Undecided → High |
| Changed in unity-scopes-api: | |
| importance: | Undecided → High |
| Changed in unity-scopes-shell: | |
| importance: | Undecided → High |
| Changed in unity-api: | |
| status: | New → In Progress |
| Changed in unity-scopes-api: | |
| status: | New → In Progress |
| Changed in unity-scopes-shell: | |
| status: | New → In Progress |
| Changed in unity-scope-click (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity8: | |
| assignee: | nobody → Michał Sawicz (saviq) |
| status: | New → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in unity-scopes-api: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Paweł Stołowski (stolowski) wrote | #4 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in unity8 (Ubuntu): | |
| status: | New → Fix Released |
| Changed in unity8: | |
| status: | In Progress → Fix Released |
| Changed in unity-scope-click (Ubuntu): | |
| status: | New → Invalid |
| no longer affects: | unity-scopes-shell |
| no longer affects: | unity-api |
| no longer affects: | unity-scopes-api |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Michał Sawicz (saviq) |
| no longer affects: | unity8 |
To post a comment you must log in.
Indeed. The unity7 way of things was to ask the scope for each result whether we should activate it or open a preview. This didn't scale well, especially for remote scopes with high round-trip times.
I'd rather see results (or categories?) annotated with "on click → preview" and "on click → activate".