Merge lp:~cimi/unity/menubaritem-reflects-ambiance-maverick-look into lp:unity

Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 520
Proposed branch: lp:~cimi/unity/menubaritem-reflects-ambiance-maverick-look
Merge into: lp:unity
Diff against target: 113 lines (+44/-26)
2 files modified
unity-private/panel/panel-indicator-object-entry-view.vala (+41/-24)
unity-private/places/places-place-search-sections-bar.vala (+3/-2)
To merge this branch: bzr merge lp:~cimi/unity/menubaritem-reflects-ambiance-maverick-look
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Review via email: mp+35797@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks awesome, approved and merged!

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

Looking at the diff, this patch has the "improved-breadcrumbs" branch merged in.
Sorry, maybe was my fault

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'unity-private/panel/panel-indicator-object-entry-view.vala'
--- unity-private/panel/panel-indicator-object-entry-view.vala 2010-09-16 12:26:48 +0000
+++ unity-private/panel/panel-indicator-object-entry-view.vala 2010-09-17 15:33:49 +0000
@@ -237,7 +237,7 @@
237 if (entry.label is Gtk.Label)237 if (entry.label is Gtk.Label)
238 {238 {
239 text = new Ctk.Text ("");239 text = new Ctk.Text ("");
240 text.color = { 233, 216, 200, 255 };240 text.color = { 223, 219, 210, 255 };
241 add_actor (text);241 add_actor (text);
242242
243 /* FIXME: What about the __ case? Well, should that me in a menu? */243 /* FIXME: What about the __ case? Well, should that me in a menu? */
@@ -533,6 +533,13 @@
533 Cairo.Context cr;533 Cairo.Context cr;
534 int width = (int)last_width;534 int width = (int)last_width;
535 int height = (int)last_height;535 int height = (int)last_height;
536 int radius = 4;
537 double x = 0;
538 double y = 0;
539 double xos = 1.5;
540 double yos = 1.5;
541 /* FIXME */
542 double mpi = 3.14159265358979323846;
536543
537 bg.set_surface_size (width, height);544 bg.set_surface_size (width, height);
538545
@@ -547,29 +554,39 @@
547554
548 cr.set_source_rgba (1.0, 1.0, 1.0, 0.2);555 cr.set_source_rgba (1.0, 1.0, 1.0, 0.2);
549556
550 cr.move_to (1, height);557 cr.move_to (x+xos+radius, y+yos);
551558 cr.arc (x+xos+width-xos*2-radius, y+yos+radius, radius, mpi*1.5, mpi*2);
552 cr.line_to (1, 7);559 cr.line_to (x+xos+width-xos*2, y+yos+height-yos*2+2);
553560 cr.line_to (x+xos, y+yos+height-yos*2+2);
554 cr.curve_to (1, 2,561 cr.arc (x+xos+radius, y+yos+radius, radius, mpi, mpi*1.5);
555 1, 2,562
556 10, 2);563 var pat = new Cairo.Pattern.linear (x+xos, y, x+xos, y+height-yos*2+2);
557564 pat.add_color_stop_rgba (0.0, 83/255.0f, 82/255.0f, 78/255.0f, 1.0f);
558 cr.line_to (width-10, 2);565 pat.add_color_stop_rgba (1.0, 66/255.0f, 65/255.0f, 63/255.0f, 1.0f);
559566 cr.set_source (pat);
560 cr.curve_to (width, 2,567 cr.fill_preserve ();
561 width, 2,568
562 width, 7);569 pat = new Cairo.Pattern.linear (x+xos, y, x+xos, y+height-yos*2+2);
563570 pat.add_color_stop_rgba (0.0, 62/255.0f, 61/255.0f, 58/255.0f, 1.0f);
564 cr.line_to (width, height);571 pat.add_color_stop_rgba (1.0, 54/255.0f, 54/255.0f, 52/255.0f, 1.0f);
565572 cr.set_source (pat);
566 cr.line_to (1, height);573 cr.stroke ();
567574
568 var pat = new Cairo.Pattern.linear (1, 0, 1, height);575 xos++;
569 pat.add_color_stop_rgba (0.0, 248/255.0f, 134/255.0f, 87/255.0f, 1.0f);576 yos++;
570 pat.add_color_stop_rgba (1.0, 236/255.0f, 113/255.0f, 63/255.0f, 1.0f);577
571 cr.set_source (pat);578 /* enlarging the area to not draw the lightborder at bottom, ugly trick :P */
572 cr.fill ();579 cr.move_to (x+radius+xos, y+yos);
580 cr.arc (x+xos+width-xos*2-radius, y+yos+radius, radius, mpi*1.5, mpi*2);
581 cr.line_to (x+xos+width-xos*2, y+yos+height-yos*2+3);
582 cr.line_to (x+xos, y+yos+height-yos*2+3);
583 cr.arc (x+xos+radius, y+yos+radius, radius, mpi, mpi*1.5);
584
585 pat = new Cairo.Pattern.linear (x+xos, y, x+xos, y+height-yos*2+3);
586 pat.add_color_stop_rgba (0.0, 92/255.0f, 90/255.0f, 85/255.0f, 1.0f);
587 pat.add_color_stop_rgba (1.0, 70/255.0f, 69/255.0f, 66/255.0f, 1.0f);
588 cr.set_source (pat);
589 cr.stroke ();
573590
574 return false;591 return false;
575 }592 }
576593
=== modified file 'unity-private/places/places-place-search-sections-bar.vala'
--- unity-private/places/places-place-search-sections-bar.vala 2010-09-13 22:00:38 +0000
+++ unity-private/places/places-place-search-sections-bar.vala 2010-09-17 15:33:49 +0000
@@ -332,8 +332,9 @@
332 x, height - radius);332 x, height - radius);
333 cr.close_path ();333 cr.close_path ();
334334
335 cr.set_source_rgba (1.0, 1.0, 1.0, 0.5);335 cr.set_source_rgba (1.0, 1.0, 1.0, 0.25);
336 cr.fill_preserve ();336 cr.fill_preserve ();
337 cr.set_source_rgba (1.0, 1.0, 1.0, 0.25);
337 cr.stroke ();338 cr.stroke ();
338339
339 var chevron = 5;340 var chevron = 5;
@@ -348,7 +349,7 @@
348 cr.move_to (point - chevron, y);349 cr.move_to (point - chevron, y);
349 cr.line_to (point + chevron, y + height/2);350 cr.line_to (point + chevron, y + height/2);
350 cr.line_to (point - chevron, y + height);351 cr.line_to (point - chevron, y + height);
351 cr.set_source_rgba (1.0, 1.0, 1.0, 1.0);352 cr.set_source_rgba (1.0, 1.0, 1.0, 0.5);
352 cr.stroke ();353 cr.stroke ();
353 }354 }
354 point += SPACING/2;355 point += SPACING/2;