Merge lp:~cimi/unity/menubaritem-reflects-ambiance-maverick-look into lp:unity

Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 520
Proposed branch: lp:~cimi/unity/menubaritem-reflects-ambiance-maverick-look
Merge into: lp:unity
Diff against target: 113 lines (+44/-26)
2 files modified
unity-private/panel/panel-indicator-object-entry-view.vala (+41/-24)
unity-private/places/places-place-search-sections-bar.vala (+3/-2)
To merge this branch: bzr merge lp:~cimi/unity/menubaritem-reflects-ambiance-maverick-look
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Review via email: mp+35797@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks awesome, approved and merged!

review: Approve
Revision history for this message
Andrea Cimitan (cimi) wrote :

Looking at the diff, this patch has the "improved-breadcrumbs" branch merged in.
Sorry, maybe was my fault

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-private/panel/panel-indicator-object-entry-view.vala'
2--- unity-private/panel/panel-indicator-object-entry-view.vala 2010-09-16 12:26:48 +0000
3+++ unity-private/panel/panel-indicator-object-entry-view.vala 2010-09-17 15:33:49 +0000
4@@ -237,7 +237,7 @@
5 if (entry.label is Gtk.Label)
6 {
7 text = new Ctk.Text ("");
8- text.color = { 233, 216, 200, 255 };
9+ text.color = { 223, 219, 210, 255 };
10 add_actor (text);
11
12 /* FIXME: What about the __ case? Well, should that me in a menu? */
13@@ -533,6 +533,13 @@
14 Cairo.Context cr;
15 int width = (int)last_width;
16 int height = (int)last_height;
17+ int radius = 4;
18+ double x = 0;
19+ double y = 0;
20+ double xos = 1.5;
21+ double yos = 1.5;
22+ /* FIXME */
23+ double mpi = 3.14159265358979323846;
24
25 bg.set_surface_size (width, height);
26
27@@ -547,29 +554,39 @@
28
29 cr.set_source_rgba (1.0, 1.0, 1.0, 0.2);
30
31- cr.move_to (1, height);
32-
33- cr.line_to (1, 7);
34-
35- cr.curve_to (1, 2,
36- 1, 2,
37- 10, 2);
38-
39- cr.line_to (width-10, 2);
40-
41- cr.curve_to (width, 2,
42- width, 2,
43- width, 7);
44-
45- cr.line_to (width, height);
46-
47- cr.line_to (1, height);
48-
49- var pat = new Cairo.Pattern.linear (1, 0, 1, height);
50- pat.add_color_stop_rgba (0.0, 248/255.0f, 134/255.0f, 87/255.0f, 1.0f);
51- pat.add_color_stop_rgba (1.0, 236/255.0f, 113/255.0f, 63/255.0f, 1.0f);
52- cr.set_source (pat);
53- cr.fill ();
54+ cr.move_to (x+xos+radius, y+yos);
55+ cr.arc (x+xos+width-xos*2-radius, y+yos+radius, radius, mpi*1.5, mpi*2);
56+ cr.line_to (x+xos+width-xos*2, y+yos+height-yos*2+2);
57+ cr.line_to (x+xos, y+yos+height-yos*2+2);
58+ cr.arc (x+xos+radius, y+yos+radius, radius, mpi, mpi*1.5);
59+
60+ var pat = new Cairo.Pattern.linear (x+xos, y, x+xos, y+height-yos*2+2);
61+ pat.add_color_stop_rgba (0.0, 83/255.0f, 82/255.0f, 78/255.0f, 1.0f);
62+ pat.add_color_stop_rgba (1.0, 66/255.0f, 65/255.0f, 63/255.0f, 1.0f);
63+ cr.set_source (pat);
64+ cr.fill_preserve ();
65+
66+ pat = new Cairo.Pattern.linear (x+xos, y, x+xos, y+height-yos*2+2);
67+ pat.add_color_stop_rgba (0.0, 62/255.0f, 61/255.0f, 58/255.0f, 1.0f);
68+ pat.add_color_stop_rgba (1.0, 54/255.0f, 54/255.0f, 52/255.0f, 1.0f);
69+ cr.set_source (pat);
70+ cr.stroke ();
71+
72+ xos++;
73+ yos++;
74+
75+ /* enlarging the area to not draw the lightborder at bottom, ugly trick :P */
76+ cr.move_to (x+radius+xos, y+yos);
77+ cr.arc (x+xos+width-xos*2-radius, y+yos+radius, radius, mpi*1.5, mpi*2);
78+ cr.line_to (x+xos+width-xos*2, y+yos+height-yos*2+3);
79+ cr.line_to (x+xos, y+yos+height-yos*2+3);
80+ cr.arc (x+xos+radius, y+yos+radius, radius, mpi, mpi*1.5);
81+
82+ pat = new Cairo.Pattern.linear (x+xos, y, x+xos, y+height-yos*2+3);
83+ pat.add_color_stop_rgba (0.0, 92/255.0f, 90/255.0f, 85/255.0f, 1.0f);
84+ pat.add_color_stop_rgba (1.0, 70/255.0f, 69/255.0f, 66/255.0f, 1.0f);
85+ cr.set_source (pat);
86+ cr.stroke ();
87
88 return false;
89 }
90
91=== modified file 'unity-private/places/places-place-search-sections-bar.vala'
92--- unity-private/places/places-place-search-sections-bar.vala 2010-09-13 22:00:38 +0000
93+++ unity-private/places/places-place-search-sections-bar.vala 2010-09-17 15:33:49 +0000
94@@ -332,8 +332,9 @@
95 x, height - radius);
96 cr.close_path ();
97
98- cr.set_source_rgba (1.0, 1.0, 1.0, 0.5);
99+ cr.set_source_rgba (1.0, 1.0, 1.0, 0.25);
100 cr.fill_preserve ();
101+ cr.set_source_rgba (1.0, 1.0, 1.0, 0.25);
102 cr.stroke ();
103
104 var chevron = 5;
105@@ -348,7 +349,7 @@
106 cr.move_to (point - chevron, y);
107 cr.line_to (point + chevron, y + height/2);
108 cr.line_to (point - chevron, y + height);
109- cr.set_source_rgba (1.0, 1.0, 1.0, 1.0);
110+ cr.set_source_rgba (1.0, 1.0, 1.0, 0.5);
111 cr.stroke ();
112 }
113 point += SPACING/2;