Code review comment for lp:~cimi/ubuntu-system-settings/wizard.wifi-fixes

Revision history for this message
Michael Terry (mterry) wrote :

It's really hard to have a conversation inline when LP clears the slate every commit. Feels weird to go back to an old commit just to reply. So I'll just reply here.

About anchors: I've certainly seen the block format before, but I've never liked it. It wastes two whole lines for no benefit. I won't block this MP on that change, but I'm not a fan, and it's certainly not related to your other code changes.

About the list: I feel like it flashes a little bit when loading. And changes around a lot when you select an entry. Is that something we can do anything about on our end?

Also, you can't deselect an entry. Not necessarily something a user will want to do often, but since there is a checkbox on the right, it feels weird that they don't act like checkboxes. The design has just a check, but not a checkbox. Could we make it look like that?

review: Needs Information

« Back to merge proposal