Merge lp:~cimi/overlay-scrollbar/use-gdk-flush-in-present-window into lp:overlay-scrollbar

Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 182
Proposed branch: lp:~cimi/overlay-scrollbar/use-gdk-flush-in-present-window
Merge into: lp:overlay-scrollbar
Diff against target: 41 lines (+7/-8)
1 file modified
os/os-scrollbar.c (+7/-8)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/use-gdk-flush-in-present-window
Reviewer Review Type Date Requested Status
Loïc Molinari (community) Approve
Review via email: mp+55317@code.launchpad.net

Description of the change

just use gdk_flush instead XSync

To post a comment you must log in.
Revision history for this message
Loïc Molinari (loic.molinari) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'os/os-scrollbar.c'
--- os/os-scrollbar.c 2011-03-29 10:35:30 +0000
+++ os/os-scrollbar.c 2011-03-29 11:16:22 +0000
@@ -114,8 +114,7 @@
114114
115/* Present a X11 window. */115/* Present a X11 window. */
116static void116static void
117os_present_window_with_timestamp (Display *default_display,117os_present_window_with_timestamp (Screen *screen,
118 Screen *screen,
119 gint xid,118 gint xid,
120 guint32 timestamp)119 guint32 timestamp)
121{120{
@@ -144,12 +143,13 @@
144 xev.xclient.data.l[4] = 0;143 xev.xclient.data.l[4] = 0;
145144
146 gdk_error_trap_push ();145 gdk_error_trap_push ();
147 XSendEvent (display,146
148 root,147 XSendEvent (display, root, False,
149 False,
150 SubstructureRedirectMask | SubstructureNotifyMask,148 SubstructureRedirectMask | SubstructureNotifyMask,
151 &xev);149 &xev);
152 XSync (default_display, False);150
151 gdk_flush ();
152
153 gdk_error_trap_pop ();153 gdk_error_trap_pop ();
154}154}
155155
@@ -158,8 +158,7 @@
158os_present_gdk_window_with_timestamp (GtkWidget *widget,158os_present_gdk_window_with_timestamp (GtkWidget *widget,
159 guint32 timestamp)159 guint32 timestamp)
160{160{
161 os_present_window_with_timestamp (GDK_DISPLAY_XDISPLAY (gdk_display_get_default ()),161 os_present_window_with_timestamp (GDK_SCREEN_XSCREEN (gtk_widget_get_screen (widget)),
162 GDK_SCREEN_XSCREEN (gtk_widget_get_screen (widget)),
163 GDK_WINDOW_XID (gtk_widget_get_window (widget)),162 GDK_WINDOW_XID (gtk_widget_get_window (widget)),
164 timestamp);163 timestamp);
165}164}

Subscribers

People subscribed via source and target branches