Code review comment for lp:~cimi/overlay-scrollbar/use-enums

Revision history for this message
Ted Gould (ted) wrote :

I think that this patch is fine. I'm curious if the states can't be turned into a pure enum without the need to handle it like a bitmask. This is still putting it in the position of being in multiple states simultaneously, which is complex to read and debug.

review: Approve

« Back to merge proposal