Merge lp:~cimi/overlay-scrollbar/unblock-thumb-callbacks into lp:overlay-scrollbar

Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 164
Proposed branch: lp:~cimi/overlay-scrollbar/unblock-thumb-callbacks
Merge into: lp:overlay-scrollbar
Diff against target: 30 lines (+3/-3)
1 file modified
os/os-scrollbar.c (+3/-3)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/unblock-thumb-callbacks
Reviewer Review Type Date Requested Status
Javier Jardón Approve
Review via email: mp+53789@code.launchpad.net

Description of the change

enter,leave and motion_notify_event_cb in os-scrollbar.c were blocking vfunc in os-thumb.c because they were returning TRUE. That was affecting the rendering of the thumb.

To post a comment you must log in.
Revision history for this message
Javier Jardón (jjardon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'os/os-scrollbar.c'
--- os/os-scrollbar.c 2011-03-16 16:17:08 +0000
+++ os/os-scrollbar.c 2011-03-17 11:31:04 +0000
@@ -721,7 +721,7 @@
721 priv->enter_notify_event = TRUE;721 priv->enter_notify_event = TRUE;
722 priv->can_hide = FALSE;722 priv->can_hide = FALSE;
723723
724 return TRUE;724 return FALSE;
725}725}
726726
727static gboolean727static gboolean
@@ -741,7 +741,7 @@
741 g_timeout_add (TIMEOUT_HIDE, os_scrollbar_hide_thumb_cb,741 g_timeout_add (TIMEOUT_HIDE, os_scrollbar_hide_thumb_cb,
742 g_object_ref (scrollbar));742 g_object_ref (scrollbar));
743743
744 return TRUE;744 return FALSE;
745}745}
746746
747static gboolean747static gboolean
@@ -838,7 +838,7 @@
838 os_scrollbar_move_thumb (scrollbar, x, y);838 os_scrollbar_move_thumb (scrollbar, x, y);
839 }839 }
840840
841 return TRUE;841 return FALSE;
842}842}
843843
844/* Move the pager to the right position. */844/* Move the pager to the right position. */

Subscribers

People subscribed via source and target branches