Code review comment for lp:~cimi/overlay-scrollbar/scrolled-window-offset

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

12 + if (GTK_SCROLLED_WINDOW (priv->parent) &&
13 + gtk_scrolled_window_get_shadow_type (GTK_SCROLLED_WINDOW (priv->parent)) != GTK_SHADOW_NONE)
14 + offset = 1;

Is guess you mean GTK_IS_SCROLLED_WINDOW() here and not just GTK_SCROLLED_WINDOW()

49 + if (GTK_SCROLLED_WINDOW (widget) &&
50 + gtk_scrolled_window_get_shadow_type (GTK_SCROLLED_WINDOW (widget)) != GTK_SHADOW_NONE)
51 + offset = 1;

Ditto.

Otherwise looks good to me, so conditionally approved with ^^ fixed :-)

review: Approve

« Back to merge proposal