Code review comment for lp:~cimi/overlay-scrollbar/insensitive-state

Revision history for this message
Ted Gould (ted) wrote :

On this line:

return gtk_widget_get_state_flags (GTK_WIDGET (scrollbar)) & GTK_STATE_FLAG_INSENSITIVE;

It would probably be better to do:

return gtk_widget_get_state_flags (GTK_WIDGET (scrollbar)) & GTK_STATE_FLAG_INSENSITIVE != 0;

So that the return value is a boolean proper. Shouldn't be an issue, but it's safer.

That's it, looks good.

review: Approve

« Back to merge proposal