Merge lp:~cimi/overlay-scrollbar/hide-thumb-more-often into lp:overlay-scrollbar

[Andrea Cimitan]

Just figure out when gtk_widget_hide (priv->thumb) is safe to be called.

[lp:~cimi/overlay-scrollbar/hide-thumb-more-often]

179. By Andrea Cimitan on 2011-03-28

comment modified

180. By Andrea Cimitan on 2011-03-29

removed some checks, they should be useless since the priv->thumb should be available to the whole lifecycle of the scrollbar object, till finalize

[Loïc Molinari (loic.molinari)]

review: Approve

=== modified file 'os/os-scrollbar.c'
--- os/os-scrollbar.c	2011-03-28 17:42:42 +0000
+++ os/os-scrollbar.c	2011-03-29 10:26:49 +0000
@@ -984,7 +984,11 @@
     {
       priv->fullsize = TRUE;
       if (priv->proximity != FALSE)
-        os_pager_hide (OS_PAGER (priv->pager));
+        {
+          os_pager_hide (OS_PAGER (priv->pager));
+
+          gtk_widget_hide (priv->thumb);
+        }
     }
 
   os_scrollbar_calc_layout_pager (scrollbar, adjustment->value);
@@ -1503,6 +1507,8 @@
 
   os_pager_hide (OS_PAGER (priv->pager));
 
+  gtk_widget_hide (priv->thumb);
+
   if (gtk_widget_get_realized (priv->parent) && priv->filter == TRUE)
     {
       priv->filter = FALSE;
@@ -1513,6 +1519,14 @@
 static void
 os_scrollbar_unrealize (GtkWidget *widget)
 {
+  OsScrollbar *scrollbar;
+  OsScrollbarPrivate *priv;
+
+  scrollbar = OS_SCROLLBAR (widget);
+  priv = scrollbar->priv;
+
+  gtk_widget_hide (priv->thumb);
+
   GTK_WIDGET_CLASS (g_type_class_peek (GTK_TYPE_WIDGET))->unrealize (widget);
 }