Merge lp:~cimi/overlay-scrollbar/fix-window-group-remove into lp:overlay-scrollbar

Proposed by Andrea Cimitan
Status: Merged
Approved by: Ted Gould
Approved revision: 279
Merged at revision: 279
Proposed branch: lp:~cimi/overlay-scrollbar/fix-window-group-remove
Merge into: lp:overlay-scrollbar
Diff against target: 50 lines (+6/-14)
1 file modified
os/os-scrollbar.c (+6/-14)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/fix-window-group-remove
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+66436@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'os/os-scrollbar.c'
--- os/os-scrollbar.c 2011-06-30 08:56:40 +0000
+++ os/os-scrollbar.c 2011-06-30 11:23:32 +0000
@@ -2437,12 +2437,6 @@
2437 os_workarea = NULL;2437 os_workarea = NULL;
2438 }2438 }
24392439
2440 if (priv->window_group != NULL)
2441 {
2442 g_object_unref (priv->window_group);
2443 priv->window_group = NULL;
2444 }
2445
2446 gdk_window_remove_filter (gdk_get_default_root_window (),2440 gdk_window_remove_filter (gdk_get_default_root_window (),
2447 root_filter_func, NULL);2441 root_filter_func, NULL);
2448 }2442 }
@@ -2453,6 +2447,12 @@
2453 priv->pager = NULL;2447 priv->pager = NULL;
2454 }2448 }
24552449
2450 if (priv->window_group != NULL)
2451 {
2452 g_object_unref (priv->window_group);
2453 priv->window_group = NULL;
2454 }
2455
2456 swap_adjustment (scrollbar, NULL);2456 swap_adjustment (scrollbar, NULL);
2457 swap_thumb (scrollbar, NULL);2457 swap_thumb (scrollbar, NULL);
24582458
@@ -2809,7 +2809,6 @@
2809static void2809static void
2810os_scrollbar_unrealize (GtkWidget *widget)2810os_scrollbar_unrealize (GtkWidget *widget)
2811{2811{
2812 GList *window_group_list;
2813 OsScrollbar *scrollbar;2812 OsScrollbar *scrollbar;
2814 OsScrollbarPrivate *priv;2813 OsScrollbarPrivate *priv;
28152814
@@ -2828,13 +2827,6 @@
28282827
2829 os_pager_set_parent (priv->pager, NULL);2828 os_pager_set_parent (priv->pager, NULL);
28302829
2831 window_group_list = gtk_window_group_list_windows (priv->window_group);
2832
2833 if (g_list_find (window_group_list, gtk_widget_get_toplevel (widget)))
2834 gtk_window_group_remove_window (priv->window_group, GTK_WINDOW (gtk_widget_get_toplevel (widget)));
2835
2836 g_list_free (window_group_list);
2837
2838 GTK_WIDGET_CLASS (g_type_class_peek (GTK_TYPE_WIDGET))->unrealize (widget);2830 GTK_WIDGET_CLASS (g_type_class_peek (GTK_TYPE_WIDGET))->unrealize (widget);
2839}2831}
28402832

Subscribers

People subscribed via source and target branches