Merge lp:~cimi/overlay-scrollbar/fix-window-group-remove into lp:overlay-scrollbar

Proposed by Andrea Cimitan
Status: Merged
Approved by: Ted Gould
Approved revision: 279
Merged at revision: 279
Proposed branch: lp:~cimi/overlay-scrollbar/fix-window-group-remove
Merge into: lp:overlay-scrollbar
Diff against target: 50 lines (+6/-14)
1 file modified
os/os-scrollbar.c (+6/-14)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/fix-window-group-remove
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+66436@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2011-06-30 08:56:40 +0000
3+++ os/os-scrollbar.c 2011-06-30 11:23:32 +0000
4@@ -2437,12 +2437,6 @@
5 os_workarea = NULL;
6 }
7
8- if (priv->window_group != NULL)
9- {
10- g_object_unref (priv->window_group);
11- priv->window_group = NULL;
12- }
13-
14 gdk_window_remove_filter (gdk_get_default_root_window (),
15 root_filter_func, NULL);
16 }
17@@ -2453,6 +2447,12 @@
18 priv->pager = NULL;
19 }
20
21+ if (priv->window_group != NULL)
22+ {
23+ g_object_unref (priv->window_group);
24+ priv->window_group = NULL;
25+ }
26+
27 swap_adjustment (scrollbar, NULL);
28 swap_thumb (scrollbar, NULL);
29
30@@ -2809,7 +2809,6 @@
31 static void
32 os_scrollbar_unrealize (GtkWidget *widget)
33 {
34- GList *window_group_list;
35 OsScrollbar *scrollbar;
36 OsScrollbarPrivate *priv;
37
38@@ -2828,13 +2827,6 @@
39
40 os_pager_set_parent (priv->pager, NULL);
41
42- window_group_list = gtk_window_group_list_windows (priv->window_group);
43-
44- if (g_list_find (window_group_list, gtk_widget_get_toplevel (widget)))
45- gtk_window_group_remove_window (priv->window_group, GTK_WINDOW (gtk_widget_get_toplevel (widget)));
46-
47- g_list_free (window_group_list);
48-
49 GTK_WIDGET_CLASS (g_type_class_peek (GTK_TYPE_WIDGET))->unrealize (widget);
50 }
51

Subscribers

People subscribed via source and target branches