Merge lp:~cimi/overlay-scrollbar/fix-783261 into lp:overlay-scrollbar

Proposed by Andrea Cimitan
Status: Merged
Approved by: Ted Gould
Approved revision: 237
Merged at revision: 237
Proposed branch: lp:~cimi/overlay-scrollbar/fix-783261
Merge into: lp:overlay-scrollbar
Diff against target: 59 lines (+14/-13)
1 file modified
os/os-thumb.c (+14/-13)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/fix-783261
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+61324@code.launchpad.net

Description of the change

Check if the widget is mapped before adding the map.
(In the review, please think about other possible checks I could add)

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'os/os-thumb.c'
--- os/os-thumb.c 2011-05-12 23:39:33 +0000
+++ os/os-thumb.c 2011-05-17 22:13:54 +0000
@@ -720,7 +720,7 @@
720720
721 priv->use_tolerance = FALSE;721 priv->use_tolerance = FALSE;
722722
723 if (priv->grabbed_widget != NULL)723 if (priv->grabbed_widget != NULL && gtk_widget_get_mapped (priv->grabbed_widget))
724 gtk_grab_add (priv->grabbed_widget);724 gtk_grab_add (priv->grabbed_widget);
725725
726 GTK_WIDGET_CLASS (os_thumb_parent_class)->unmap (widget);726 GTK_WIDGET_CLASS (os_thumb_parent_class)->unmap (widget);
@@ -754,14 +754,14 @@
754 priv = thumb->priv;754 priv = thumb->priv;
755755
756 switch (prop_id)756 switch (prop_id)
757 {757 {
758 case PROP_ORIENTATION:758 case PROP_ORIENTATION:
759 g_value_set_enum (value, priv->orientation);759 g_value_set_enum (value, priv->orientation);
760 break;760 break;
761761
762 default:762 default:
763 break;763 break;
764 }764 }
765}765}
766766
767static void767static void
@@ -777,8 +777,9 @@
777 priv = thumb->priv;777 priv = thumb->priv;
778778
779 switch (prop_id)779 switch (prop_id)
780 {780 {
781 case PROP_ORIENTATION: {781 case PROP_ORIENTATION:
782 {
782 priv->orientation = g_value_get_enum (value);783 priv->orientation = g_value_get_enum (value);
783 if (priv->orientation == GTK_ORIENTATION_VERTICAL)784 if (priv->orientation == GTK_ORIENTATION_VERTICAL)
784 {785 {
@@ -793,9 +794,9 @@
793 break;794 break;
794 }795 }
795796
796 default:797 default:
797 break;798 break;
798 }799 }
799}800}
800801
801/* Public functions. */802/* Public functions. */

Subscribers

People subscribed via source and target branches