Code review comment for ~chrispitude/beautifulsoup:new-tag-allow-text

Revision history for this message
Leonard Richardson (leonardr) wrote :

This looks good for the next feature release. The only change I plan to make is to move 'string' to the end of the argument list to maintain backwards compatibility. Otherwise existing code that uses positional arguments (like the tree builder code you had to change) will break.

« Back to merge proposal