Code review comment for lp:~chris.gagnon/phablet-tools/fix_1289525

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

How about not using the find_active_network_again and replacing the original network_file= with
sudo grep -H "$network_active_uuid" /etc/NetworkManager/system-connections/* | grep uuid | cut -f1 -d:

That should return the file that has that uuid; seems less error prone as well.

I'm adding Andy so he can review as well against ci.

There also seems to be some tabbing going on in your changes.

Additionally, the original can be improve if
if [ -z "$network_active_uuid" ]

is done before finding out which network file holds the conf for the uuid.

review: Needs Fixing

« Back to merge proposal