Merge lp:~chris-rassalon/vmbuilder/execscript into lp:vmbuilder

Proposed by Chris R. Jones
Status: Merged
Merged at revision: 465
Proposed branch: lp:~chris-rassalon/vmbuilder/execscript
Merge into: lp:vmbuilder
Diff against target: 22 lines (+1/-1)
2 files modified
VMBuilder/distro.py (+0/-1)
VMBuilder/hypervisor.py (+1/-0)
To merge this branch: bzr merge lp:~chris-rassalon/vmbuilder/execscript
Reviewer Review Type Date Requested Status
Serge Hallyn Approve
Review via email: mp+61170@code.launchpad.net

Description of the change

Delays the execution of --execscript scripts until after just before the chroot fs is unmounted. This allows the user to do customization to the VM after all of its installation steps are complete, where currently, they have no ability to customize kernel, grub, network and filesytems mounts from their execscript.

To post a comment you must log in.
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks for your time improving vmbuilder.

Please sign the contributor agreement so we can accept this patch.

https://wiki.canonical.com/LegalServices/Forms/ContributorAgreement

Revision history for this message
Chris R. Jones (chris-rassalon) wrote :

> Thanks for your time improving vmbuilder.
>
> Please sign the contributor agreement so we can accept this patch.
>
> https://wiki.canonical.com/LegalServices/Forms/ContributorAgreement

Sure, replied with the form through email. That link didn't work for me, but followed the directions at http://www.canonical.com/contributors. Let me know if you need something else.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks very much, Chris. Pushing to oneiric right now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'VMBuilder/distro.py'
2--- VMBuilder/distro.py 2010-12-13 15:22:11 +0000
3+++ VMBuilder/distro.py 2011-05-16 20:17:36 +0000
4@@ -82,7 +82,6 @@
5 self.call_hooks('set_defaults')
6 self.call_hooks('bootstrap')
7 self.call_hooks('configure_os')
8- self.call_hooks('post_install')
9 self.cleanup()
10
11 def has_xen_support(self):
12
13=== modified file 'VMBuilder/hypervisor.py'
14--- VMBuilder/hypervisor.py 2010-04-07 19:47:58 +0000
15+++ VMBuilder/hypervisor.py 2011-05-16 20:17:36 +0000
16@@ -68,6 +68,7 @@
17 if self.needs_bootloader:
18 self.call_hooks('install_bootloader', self.chroot_dir, self.disks)
19 self.call_hooks('install_kernel', self.chroot_dir)
20+ self.distro.call_hooks('post_install')
21 self.call_hooks('unmount_partitions')
22 os.rmdir(self.chroot_dir)
23

Subscribers

People subscribed via source and target branches