Merge lp:~chocanto/file-qml-plugin/debian into lp:file-qml-plugin

[Anthony Granger]

Debian packaging

Initial merge of debian packaging

[Nekhelesh Ramananthan (nik90)]

I start this review by stating that I am no debian expert. I am merely comparing this debian folder with the clock app and my own judgement. Please fix the following in a separate commit so that it is easy to see if they have been fixed.

[Nekhelesh Ramananthan (nik90)]

25 +Maintainer: Ubuntu App Cats <email address hidden>

I am wondering why the Ubuntu App Cats is the maintainer of this library. Shouldn't it be you? I guess you need to decide if you are going to merge it to the core apps PPA in which case the above is correct, otherwise you need to change this.

review: Needs Information

[Nekhelesh Ramananthan (nik90)]

48 +Files: *
49 +Copyright: 2013 Canonical Ltd.
50 +License: GPL-3

Here you can remove the 2013 Canonical Ltd. and replace it with the contributors's names in the format,

Name <email>

The rest of the copyright seems okay.

review: Needs Fixing

[Nekhelesh Ramananthan (nik90)]

45 +Upstream-Name: qtdeclarative5-poppler-qml-plugin

It would be preferable if this upstream package name is the same as the soruce package name itself.

[Nekhelesh Ramananthan (nik90)]

34 +Architecture: any

Please cross check this with others. Since the qml plugin is c++, we need to be careful about this.

review: Needs Information

[lp:~chocanto/file-qml-plugin/debian]

8. By Anthony Granger on 2013-09-24

Change maintainer of the package and some informations in the copyright file

=== added directory 'debian'
=== added file 'debian/changelog'
--- debian/changelog	1970-01-01 00:00:00 +0000
+++ debian/changelog	2013-09-24 18:33:53 +0000
@@ -0,0 +1,5 @@
+file-qml-plugin (0.1-1) saucy; urgency=low
+
+  * Initial release
+
+ -- Granger Anthony <[e-mail]>  Mon, 23 Sep 2013 14:51:00 +0200
 
=== added file 'debian/compat'
--- debian/compat	1970-01-01 00:00:00 +0000
+++ debian/compat	2013-09-24 18:33:53 +0000
@@ -0,0 +1,1 @@
+8
 
=== added file 'debian/control'
--- debian/control	1970-01-01 00:00:00 +0000
+++ debian/control	2013-09-24 18:33:53 +0000
@@ -0,0 +1,17 @@
+Source: file-qml-plugin
+Section: libs
+Priority: extra
+Maintainer: Anthony Granger <[e-mail]>
+Build-Depends: debhelper (>= 9),
+			qt5-default,
+			qtbase5-dev,
+			qtdeclarative5-dev
+Standards-Version: 3.9.4
+Homepage: https://launchpad.net/file-qml-plugin
+Vcs-Bzr: https://code.launchpad.net/~chocanto/file-qml-plugin/trunk
+
+Architecture: any
+Package: file-qml-plugin
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: File access plugin for QML
+ This package contains a simple QML plugin to read a file.
 
=== added file 'debian/copyright'
--- debian/copyright	1970-01-01 00:00:00 +0000
+++ debian/copyright	2013-09-24 18:33:53 +0000
@@ -0,0 +1,45 @@
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: file-qml-plugin
+Source:
+
+Files: *
+Copyright: Anthony Granger <[e-mail]>
+License: GPL-3
+
+Files: debian/*
+Copyright: Anthony Granger <[e-mail]>
+License: LGPL-3
+
+License: GPL-3
+ This package is free software; you can redistribute it and/or
+ modify it under the terms of the GNU General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License.
+ .
+ This package is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the complete text of the GNU General
+ Public License can be found in "/usr/share/common-licenses/GPL-3".
+
+License: LGPL-3
+ This package is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License.
+ .
+ This package is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ Lesser General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the complete text of the GNU Lesser General
+ Public License can be found in "/usr/share/common-licenses/LGPL-3".
 
=== added file 'debian/rules'
--- debian/rules	1970-01-01 00:00:00 +0000
+++ debian/rules	2013-09-24 18:33:53 +0000
@@ -0,0 +1,11 @@
+#!/usr/bin/make -f
+# -*- makefile -*-
+
+# Uncomment this to turn on verbose mode.
+#export DH_VERBOSE=1
+
+%:
+	dh $@ 
+
+override_dh_install:
+	dh_install --fail-missing
 
=== added directory 'debian/source'
=== added file 'debian/source/format'
--- debian/source/format	1970-01-01 00:00:00 +0000
+++ debian/source/format	2013-09-24 18:33:53 +0000
@@ -0,0 +1,1 @@
+1.0