Merge lp:~chmouel/testrepository/coverage-package-name into lp:~testrepository/testrepository/trunk

[Chmouel Boudjnah]

[Marc Abramowitz (msabramo)]

+1. Just ran into this issue today with pbr (my own change request for pbr: https://review.openstack.org/89205).

I can't decide whether I like your name for the option better ("coverage-package-name") or mine ("source"). Your seems clearer and more explicit, though mine matches the name of the option passed to coverage. I don't know. I could go either way.

review: Approve

[Marc Abramowitz (msabramo)]

https://review.openstack.org/#/c/89205/ was merged for pbr, which adds this same option.

Monty released pbr 0.8.1 with --coverage-package-name option (thanks, Monty!)

[Robert Collins (lifeless)]

Hi! Could you repropose this to master - https://github.com/testing-cabal/testrepository? Thanks!

review: Needs Fixing

[Marc Abramowitz (msabramo)]

Yep, see https://github.com/testing-cabal/testrepository/pull/7

Unmerged revisions

241. By Chmouel Boudjnah on 2014-03-28

Add coverage package name

Allow to specify a different package name than the one from the setp.cfg
project.

Fixes bug #1298398

=== modified file 'testrepository/setuptools_command.py'
--- testrepository/setuptools_command.py	2013-07-10 11:50:45 +0000
+++ testrepository/setuptools_command.py	2014-03-28 09:35:05 +0000
@@ -41,6 +41,7 @@
         ('coverage', None, "Replace PYTHON with coverage and merge coverage "
          "from each testr worker."),
         ('testr-args=', 't', "Run 'testr' with these args"),
+        ('coverage-package-name=', None, "Use this name for coverage package"),
         ('omit=', 'o', 'Files to omit from coverage calculations'),
         ('slowest', None, "Show slowest test times after tests complete."),
     ]
@@ -56,6 +57,7 @@
         self.coverage = None
         self.omit = ""
         self.slowest = None
+        self.coverage_package_name = None
 
     def finalize_options(self):
         if self.testr_args is None:
@@ -86,6 +88,10 @@
         package = self.distribution.get_name()
         if package.startswith('python-'):
             package = package[7:]
+
+        # Use this as coverage package name
+        if self.coverage_package_name:
+            package = self.coverage_package_name
         options = "--source %s --parallel-mode" % package
         os.environ['PYTHON'] = ("coverage run %s" % options)