Code review comment for lp:~chiradeep/nova/msft-hyper-v-support

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Hi Chiradeep,

thanks for the reply!

One more thing: the naming convention for unittest files has changed from <testname>_unittest.py to test_<testname>.py. I noticed that without renaming your test, run_test.sh does not process the file.

If you do rename the file, then the test will be run and (in my case) it fails because of a missing wmi module.

My take is that if the test isn't ready, it's better to remove it from the diff, as this might delay the merging process.

« Back to merge proposal