Code review comment for lp:~chiradeep/nova/msft-hyper-v-support

Revision history for this message
Chiradeep Vittal (chiradeep) wrote :

Yes the test case is indeed broken. I am inclined to delete it since the
reviewers want a test case that can run without hyper-v. This would
involve a large amount of mocking of the Hyper-V WMI provider.

On 01/05/2011 05:02 AM, Armando Migliaccio wrote:
> A couple of questions about the unittest provided with this branch:
>
> - does the test require an actual connection to hyperv? I couldn't find where this is stubbed out
> - any particular reasons of calling the private method _create_vm, rather the public spawn method?
> - does this test actually run/pass at all?
>
> The call to
>
> instance_ref = db.instance_create(None, instance)
>
> should raise an exception about the deprecation of a null context
>

« Back to merge proposal