Code review comment for lp:~chiradeep/nova/msft-hyper-v-support
Revision history for this message
| Chiradeep Vittal (chiradeep) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Fixed.
-- Removed dependencies on twisted
-- fixed logging and exceptions strings to enable i18n
-- removed redis dependency in unittest
On 01/03/2011 01:27 AM, Soren Hansen wrote:
> Review: Needs Fixing
> Chiradeep, this branch needs to be updated to the new, Twistedless world order. You need to get rid of the yields, you probably don't need the changes to nova/twistd.py anymore. Also, a round of testing to check that it still actually works would probably be a good idea :)
>
> I'm also not sure you still need the redis_host stuff?
>